Bug 118065 – [patch] kde-misc/yakuake and $0 in user shell was -l

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description David Watzke 2006-01-06 09:55:03 UTC]

Hi. I found a bug in YaKuake. See this:

$ echo $0
-l

only as user...

after apply the patch it's okay...

$ echo $0
/bin/bash

Please, revbump to 2.7.3-r1. :-)

[Comment 1 David Watzke 2006-01-06 09:55:46 UTC]

Created attachment 76360 [details, diff]
src/shell_session.cpp

patch

[Comment 2 David Watzke 2006-01-06 10:02:20 UTC]

Created attachment 76361 [details, diff]
src/shell_session.cpp

better patch

[Comment 3 David Watzke 2006-01-06 10:10:10 UTC]

Huh, new 'better patch' doesn't compile on amd64. :(

[Comment 4 David Watzke 2006-01-06 10:40:05 UTC]

Compiles.. it was my bad. Sorry.

[Comment 5 David Watzke 2006-01-06 10:55:47 UTC]

Comment on attachment 76361 [details, diff]
src/shell_session.cpp

>*** shell_session.cpp	2006-01-06 18:46:03.000000000 +0100
>--- shell_session.cpp-ok	2006-01-06 18:47:17.000000000 +0100
>***************
>*** 47,56 ****
>  
>          session_terminal = (TerminalInterface *) (session_part->qt_cast("TerminalInterface"));
>  
>-         args.append("-l");
>          shell = getenv("SHELL");
>          if (shell == NULL || *shell == '\0')
>              shell = "/bin/sh";
>  
>          session_terminal->startProgram(shell, args);
>  
>--- 47,57 ----
>  
>          session_terminal = (TerminalInterface *) (session_part->qt_cast("TerminalInterface"));
>  
>          shell = getenv("SHELL");
>          if (shell == NULL || *shell == '\0')
>              shell = "/bin/sh";
>+         args.append(strrchr(shell, '/') ? strrchr(shell, '/') : shell);
>+         args.append("-l");
>  
>          session_terminal->startProgram(shell, args);
>

[Comment 6 Marcus D. Hanwell (RETIRED) 2006-01-06 12:00:36 UTC]

Have you reported this upstream? It should be reported there also. I am just on the way out right now, but will take a look tomorrow hopefully.

[Comment 7 David Watzke 2006-01-06 12:35:11 UTC]

Yeah, I've reported it...

[Comment 8 Marcus D. Hanwell (RETIRED) 2006-01-08 10:03:12 UTC]

This is a minor bug - I would like to see what upstream decides to do first. Unless anyone else in the KDE herd disagrees.

[Comment 9 David Watzke 2006-03-21 22:26:32 UTC]

Resolved upstream (0.7.5).