Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 118025 - app-arch/cabextract: patch configure.ac unconditionally
Summary: app-arch/cabextract: patch configure.ac unconditionally
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Fonts Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-06 05:02 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2006-04-18 13:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
cabextract-1.1-mempcpy.patch (cabextract-1.1-mempcpy.patch,488 bytes, patch)
2006-01-06 05:03 UTC, Diego Elio Pettenò (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2006-01-06 05:02:34 UTC 
Currently cabextract applies a conditional patch to configure script. This does work, but it's always better to patch configure.ac file instead, and re-run autotools to make sure that it does not get recreated with colliding autotools versions.

The attached (simpler) patch removes the check from configure.ac, it can be done unconditionally as it does not create problems to other arches.
After that, the ebuild should call eautoreconf (and add inherit autotools) so that the support is recreated.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-01-06 05:03:17 UTC 
Created attachment 76327 [details, diff]
cabextract-1.1-mempcpy.patch
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-04-18 13:14:49 UTC 
Patch committed.