Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 117546 - ndiswrapper ebuild fails while trying to re-install windows drivers
Summary: ndiswrapper ebuild fails while trying to re-install windows drivers
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mobile Herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-02 23:45 UTC by Carlo Marcelo Arenas Belon
Modified: 2006-06-23 09:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
"obvious" patch to the problem (ndiswrapper-reinstall.patch,532 bytes, patch)
2006-01-03 01:02 UTC, Carlo Marcelo Arenas Belon
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlo Marcelo Arenas Belon 2006-01-02 23:45:56 UTC
as shown by :

 * Attempting to automatically reinstall any Windows drivers
 * you might already have.
 * Driver: netbc564
mv: cannot overwrite directory `/tmp/netbc564'
netbc564 is already installed. Use -e to remove it

how to reproduce :

  `module-rebuild rebuild` twice

problems :

* mv won't succeed if another directory with the same name already exists
* if forced, it will lead to a security problem (race condition)
* assumes /tmp is available as a TMPDIR
* leaves /tmp dirty
Comment 1 Carlo Marcelo Arenas Belon 2006-01-03 01:02:22 UTC
Created attachment 76051 [details, diff]
"obvious" patch to the problem

still problematic as :

0) not tested
1) not using a real lock and therefore has a race condition between the test and the mv/rm
2) probably still violates the sandbox rules by using ${TMPDIR}
Comment 2 Petteri Räty (RETIRED) gentoo-dev 2006-06-22 05:33:57 UTC
(In reply to comment #1)
> Created an attachment (id=76051) [edit]
> "obvious" patch to the problem
> 
> still problematic as :
> 
> 0) not tested
> 1) not using a real lock and therefore has a race condition between the test
> and the mv/rm
> 2) probably still violates the sandbox rules by using ${TMPDIR}
> 

Well I think I fixed this by switching to using ${T} that should be used within ebuilds. Please test ndiswrapper-1.17 and reopen if not fixed well enough. I don't have the hardware at hand atm so I can't test.
Comment 3 Carlo Marcelo Arenas Belon 2006-06-23 09:07:48 UTC
confirmed: works like a charm, thanks