Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 117528 - net-proxy/pingtunnel minor ebuild fix
Summary: net-proxy/pingtunnel minor ebuild fix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Network Proxy Developers (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-02 19:23 UTC by Christopher Covington
Modified: 2006-01-06 03:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed patch (pingtunnel-0.61-to-0.61-r1.patch,1.08 KB, patch)
2006-01-02 19:26 UTC, Christopher Covington
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Covington 2006-01-02 19:23:08 UTC
I just spent my evening writing an ebuild for this app before realizing it was in portage. The ebuild might be able to be improved.

1. There is a libpcap virtual which could be used. I can't test it though, I found--can't create _any_ sockets on my web server :(.

2. The package is called pingtunnel but the binary and man page are called ptunnel. There are some other apps out there (but I don't think in portage) that go by the name of ptunnel so probably pingtunnel is better.

3. There is some html documentation that isn't installed.

4. Lastly, I don't know if this is really an important style thing or not, but in the patch I used the $MY_P and $MY_PN instead of static strings.
Comment 1 Christopher Covington 2006-01-02 19:26:26 UTC
Created attachment 76035 [details, diff]
proposed patch
Comment 2 Alin Năstac (RETIRED) gentoo-dev 2006-01-06 03:40:12 UTC
(In reply to comment #0)
> 1. There is a libpcap virtual which could be used. I can't test it though, I
> found--can't create _any_ sockets on my web server :(.

the net-libs/libpcap-ringbuffer package is broken and it shouldn't provide virtual/libpcap (see bug #117898)

> 2. The package is called pingtunnel but the binary and man page are called
> ptunnel. There are some other apps out there (but I don't think in portage)
> that go by the name of ptunnel so probably pingtunnel is better.

unless there is a conflict, I prefer to stick with whatever names were chosed by upstream. It would mean more than a simple file rename.

> 3. There is some html documentation that isn't installed.

added depending on "doc" useflag.

> 4. Lastly, I don't know if this is really an important style thing or not, but
> in the patch I used the $MY_P and $MY_PN instead of static strings.

I prefer the other way. It is more readable and I doubt "PingTunnel" will be ever changed by upstream.

I've commited 3) along with a minor modification in Makefile sed, but I didn't bump the revision. The doc useflag is the only change worth reemerging for and "emerge -uDN world" will do that anyway.