Bug 117331 – Firefox 1.5: patches to fix symbol visibility issues

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Simon Strandman 2006-01-01 02:35:14 UTC]

Symbol visibility is disabled by default in the firefox 1.5 ebuild. This is bad for performance. Enabling symbol visibility makes firefox noticeable faster and might increase page rendering by up to 5%.

I have two patches that fixes symbol visibility for amd64 and other previously broken arches. The first is from mozilla bug #307168 and adds a configure check for the visibility pragma bug and enables building with -fvisibility=hidden instead if it's found, and the other is extracetd from firefox cvs and fixes the exports.

[Comment 1 Simon Strandman 2006-01-01 02:36:52 UTC]

Created attachment 75897 [details, diff]
Configure check for visibility pragma bug

This patch adds the configure check for the visibility pragma bug, resynced against firefox 1.5.

[Comment 2 Simon Strandman 2006-01-01 02:37:53 UTC]

Created attachment 75898 [details, diff]
Export fix

And this is the fix. Otherwise firefox wont start with unresolved symbol errors.

[Comment 3 Simon Strandman 2006-01-01 02:46:31 UTC]

Oh I forgot to mention, autoreconf-2.13 needs to be run after applying these patches since configure.in is changed.

[Comment 4 Jory A. Pratt 2006-01-08 09:40:14 UTC]

Thanks for searching upstream for updated patches.