Bug 117261 – Python on Gentoo/OpenBSD

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Karol Pasternak (RETIRED) 2005-12-31 03:29:14 UTC]

Python doesn't compiling on Gentoo/OpenBSD. Conditional patches for openbsd are required.

[Comment 1 Karol Pasternak (RETIRED) 2005-12-31 03:30:28 UTC]

Created attachment 75856 [details, diff]
patch for configure.in

[Comment 2 Karol Pasternak (RETIRED) 2005-12-31 03:30:53 UTC]

Created attachment 75857 [details, diff]
Patch for Makefile.pre.in

[Comment 3 Karol Pasternak (RETIRED) 2005-12-31 03:32:12 UTC]

Created attachment 75858 [details, diff]
Patch for Include/Python.h

[Comment 4 Diego Elio Pettenò (RETIRED) 2005-12-31 03:50:22 UTC]

No conditional patching will be allowed for anything but toolchain packages (gcc/binutils, and only because they are way too complex).

Please rework the patches in a single portable patch. The Makefile.pre.in can probably be ignored, as it just changes the way the library is named, and we don't really care to maintain the same naming as the original distribution rather than the one provided by the package itself (and also, the linux naming on other elf operating systems make sense, for Gentoo/FreeBSD we were able to get rid of one big problems they had: the need to recompile everything linking to something at every bump).

The Include/Python.h is probably fine, the configure.in needs a bit of work in the last part, have to check $host_os to use -pthread on OpenBSD and the check for the rest of the systems.

[Comment 5 Karol Pasternak (RETIRED) 2005-12-31 06:28:55 UTC]

Created attachment 75867 [details, diff]
More flexible patch

ok, i write more flexible patch for python this time... 
It can be used with another patches.
Tested under linux and obsd.

[Comment 6 Diego Elio Pettenò (RETIRED) 2005-12-31 06:56:04 UTC]

We're not yet there.
The conditional on sys/types.h is not needed, just include it, should be safe everywhere.

uname is _not_ safe in configure to use, use the $host_os variable to check that (and you miss a fi).

the check for OpenBSD moved out of FreeBSD is really needed? Consider that we're going to support only ELF target and not 0/1/2 major versions, try to limit the changes if possible.

[Comment 7 Karol Pasternak (RETIRED) 2006-01-03 00:06:10 UTC]

Created attachment 76049 [details, diff]
Final version of patch, i hope:>

[Comment 8 Diego Elio Pettenò (RETIRED) 2006-01-03 00:16:45 UTC]

Yeah that's fine :)
Moving to python herd then.

Also, submit it upstream, they'll be probably be happy to apply it.

[Comment 9 Bryan Østergaard (RETIRED) 2006-04-14 05:56:07 UTC]

Added to python-2.4.2-r1 and 2.4.3.

[Comment 10 Karol Pasternak (RETIRED) 2006-04-26 10:24:13 UTC]

reopening bug [depend on #130140]

kloeri or anyone from python herd, can you remove old patch for Gentoo/OpenBSD (you know why) and add this one: http://dev.gentoo.org/~reb/obsd/patches/python-2.4-gentoo_obsd.patch ?
(with added __OpenBSD__ macro for including header)

Now gnome-python compiles fine
>>> dev-python/gnome-python-2.12.3 merged. :)

Karol

[Comment 11 Phil Richards 2006-04-29 05:07:49 UTC]

Can somebody *please* release this new patch?  It fixes Bug #130140 (been open for just about 2 weeks now) - this is something that is breaking gnome-python on Linux ~x86 and has a knock-on effect for GNOME 2.14.

[Comment 12 James 2006-05-01 07:04:39 UTC]

anyone out there want to submit this patch upstream

[Comment 13 Bryan Østergaard (RETIRED) 2006-05-04 07:41:54 UTC]

Fixed patch in cvs now as python-2.4.2-r2 and python-2.4.3-r1.