Bug 116745 – modules-update from 1.12.0_pre12 leaves /etc/modprobe.conf.xxx.err file around

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Daniele Gaffuri 2005-12-25 16:43:50 UTC]

Hi

After upgrading to baselayout-1.12.0_pre12 I find a file named /etc/modprobe.conf.xxx.err, where xxx is a pid, each time I run a modules-update command.

The contents is

modprobe: QM_MODULES: Function not implemented

Warning: not translating Note: /etc/modules.conf is more recent than /lib/modules/2.6.15-rc7/modules.dep
Warning: not translating path[toplevel]=/lib/modules/2.6

This seems to be (or better to contain, I don't know where the Note comes from) the stderr of

if /sbin/generate-modprobe.conf ${ASSUME_KV:+--assume-kernel=${KV}} \
                        >> "${TMPFILE2}" 2> "${TMPFILE2}.err" ; then

at line 199 of /sbin/modules-update. This patch removes the file if command is OK:

--- modules-update.orig 2005-12-26 01:39:44.000000000 +0100
+++ modules-update      2005-12-26 01:39:56.000000000 +0100
@@ -228,8 +228,8 @@ if ${FORCE} || is_older_than ${CFGFILE2}
                                fi
                                rm -f "${TMPFILE2}" "${TMPFILE2B}.err"
                        fi
-                       rm -f "${TMPFILE2}.err"
                fi
+               rm -f "${TMPFILE2}.err"

                if [[ -f ${CFGFILE3} ]] ; then
                        ebegin "Updating ${CFGFILE4}"

Is it correct?

Thanks

[Comment 1 SpanKY 2005-12-25 19:52:13 UTC]

we should also display the file if there was an error, so ive added both of these things to svn

thanks