Bug 116459 – make libpng-1.2.8-r1 work with --as-needed

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Prakash Punnoor 2005-12-22 23:46:16 UTC]

libpng gives linker errors if you try to compile with -Wl,--as-needed. This patch fixes it.

[Comment 1 Prakash Punnoor 2005-12-22 23:46:56 UTC]

Created attachment 75380 [details, diff]
fix for --as-needed breakage

[Comment 2 SpanKY 2005-12-23 06:25:41 UTC]

libpng uses functions in libm

[Comment 3 Prakash Punnoor 2005-12-23 06:39:33 UTC]

??? That's why I explicitly link to libm...

[Comment 4 SpanKY 2005-12-23 06:58:38 UTC]

no, you remove the libpng.so linking to libm.so

[Comment 5 Prakash Punnoor 2005-12-23 07:04:03 UTC]

Well, if you look *closely* at the patch and perhaps the Makefile, you'd see you are wrong, I just change the position. Don't get confused by the first line. Hrrmm.

[Comment 6 SpanKY 2005-12-23 07:27:08 UTC]

Comment on attachment 75380 [details, diff]
fix for --as-needed breakage

your patch does just move the -lm usage, however it's still wrong

you didnt fix the real issue

[Comment 7 SpanKY 2005-12-23 15:16:42 UTC]

fixed properly in cvs, thanks for the bug report