Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 116379 - spca5xx needs a small patch with most recent kernels
Summary: spca5xx needs a small patch with most recent kernels
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mike Doty (RETIRED)
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2005-12-22 05:47 UTC by Alexandre Buisse (RETIRED)
Modified: 2006-04-14 08:57 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to compile spca5xx with latest kernel (spca5xx-20051212-mm-kernel.patch,349 bytes, patch)
2005-12-22 05:48 UTC, Alexandre Buisse (RETIRED)
Details | Diff
Patch for spca5xx-20060101 (spca5xx-mm-kernel.patch,383 bytes, patch)
2006-01-26 02:25 UTC, Alexandre Buisse (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Buisse (RETIRED) gentoo-dev 2005-12-22 05:47:48 UTC
With spca5xx-20051212 (which is also the latest version upstream atm) and kernel 2.6.15-rc2-mm1, there is a compilation problem :

  CC [M]  /var/tmp/portage/spca5xx-20051212/work/spca5xx-20051212/drivers/usb/spca5xx.o
/var/tmp/portage/spca5xx-20051212/work/spca5xx-20051212/drivers/usb/spca5xx.c: In function 
Comment 1 Alexandre Buisse (RETIRED) gentoo-dev 2005-12-22 05:47:48 UTC
With spca5xx-20051212 (which is also the latest version upstream atm) and kernel 2.6.15-rc2-mm1, there is a compilation problem :

  CC [M]  /var/tmp/portage/spca5xx-20051212/work/spca5xx-20051212/drivers/usb/spca5xx.o
/var/tmp/portage/spca5xx-20051212/work/spca5xx-20051212/drivers/usb/spca5xx.c: In function spca50x_configure:
/var/tmp/portage/spca5xx-20051212/work/spca5xx-20051212/drivers/usb/spca5xx.c:5380: warning: defaultpipe may be used uninitialized in this function
/var/tmp/portage/spca5xx-20051212/work/spca5xx-20051212/drivers/usb/spca5xx.c:5379: warning: defaultrows may be used uninitialized in this function
/var/tmp/portage/spca5xx-20051212/work/spca5xx-20051212/drivers/usb/spca5xx.c:5378: warning: defaultcols may be used uninitialized in this function
/var/tmp/portage/spca5xx-20051212/work/spca5xx-20051212/drivers/usb/spca5xx.c: At top level:
/var/tmp/portage/spca5xx-20051212/work/spca5xx-20051212/drivers/usb/spca5xx.c:8550: error: unknown field owner specified in initializer
/var/tmp/portage/spca5xx-20051212/work/spca5xx-20051212/drivers/usb/spca5xx.c:8550: warning: initialization from incompatible pointer type


It seems the usb_driver structure has changed in latest versions, so I simply deleted line 8550 that fills the ".owner" field of that struct and compilation went fine. After that, my Creative NX Ultra worked like a charm.

I attached the patch, you may want to include it in the ebuild (I don't think it will harm people that are using older kernels, though I didn't test it).
Comment 2 Alexandre Buisse (RETIRED) gentoo-dev 2005-12-22 05:48:42 UTC
Created attachment 75321 [details, diff]
Patch to compile spca5xx with latest kernel
Comment 3 Thomas Kjosmoen 2005-12-22 21:06:29 UTC
Please add this patch to portage. It fixed my problem as well, using mm-sources-2.6.15_rc5-r2.
Comment 4 Mike Doty (RETIRED) gentoo-dev 2006-01-07 07:23:05 UTC
use 20060101 please
Comment 5 Alexandre Buisse (RETIRED) gentoo-dev 2006-01-26 02:15:57 UTC
Still happens with 20060101 and kernel 2.6.15-mm4

emerge --info: 

Portage 2.1_pre3-r1 (default-linux/x86/2005.0, gcc-4.0.1, glibc-2.3.6-r2, 2.6.15-mm4-ubik i686)
=================================================================
System uname: 2.6.15-mm4-ubik i686 Intel(R) Pentium(R) M processor 1.70GHz
Gentoo Base System version 1.12.0_pre14
dev-lang/python:     2.3.5-r2, 2.4.2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1-r1
sys-devel/libtool:   1.5.20
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i386-pc-linux-gnu"
CFLAGS="-O2 -mtune=i686 -fomit-frame-pointer"
CHOST="i386-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/share/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/splash /etc/terminfo /etc/texmf/web2c /etc/env.d"
CXXFLAGS="-O2 -mtune=i686 -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig cvs distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://ftp.rhnet.is/pub/gentoo http://mirror.gentoo.no http://gentoo.mirror.sdv.fr ftp://ftp.uni-erlangen.de/pub/mirrors/gentoo http://gentoo.oregonstate.edu http://www.ibiblio.org/pub/Linux/distributions/gentoo"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/home/heimdall/gentoo/gentoo-x86"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X aac aalib acl acpi alsa audiofile avi bash-completion berkdb bitmap-fonts bzip2 canna cdb cdr cjk crypt cups curl directfb dlloader doc dri dvd dvdr dvdread eds emboss encode esd ethereal exif expat fam fbcon ffmpeg flac font-server foomaticdb fortran gcj gd gdbm gif gimpprint glitz glut gmp gnome gphoto2 gpm graphviz gstreamer gtk gtk2 gtkhtml guile icecast idn imagemagick imap imlib java jpeg junit lcms ldap libcaca libg++ libwww lua mad mbox mikmod mmx mng motif mozsvg mp3 mpeg musepack musicbrainz nas ncurses networkcanna nls nntp nptl objc offensive ogg oggvorbis openal opengl pam pcre pdflib perl png python quicktime radeon readline real recode ruby samba sasl sdl slang softmmu speex spell sqlite sse sse2 ssl svg svga tcltk tcpd tetex tiff truetype truetype-fonts type1-fonts udev unicode usb userlocales v4l vidix vorbis win32codecs xine xml xml2 xmms xv xvid zlib elibc_glibc kernel_linux userland_GNU"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS, MAKEOPTS
Comment 6 Alexandre Buisse (RETIRED) gentoo-dev 2006-01-26 02:25:57 UTC
Created attachment 78142 [details, diff]
Patch for spca5xx-20060101
Comment 7 Mike Doty (RETIRED) gentoo-dev 2006-01-26 09:51:17 UTC
(In reply to comment #5)
> Created an attachment (id=78142) [edit]
> Patch for spca5xx-20060101
> 

I think this must be mm specific as I don't hit the bug with gentoo-sources-2.6.15-r1.  could you try with gentoo-sources or vanilla?
Comment 8 Andrej Kacian (RETIRED) gentoo-dev 2006-03-18 06:50:12 UTC
Works here on suspend2-sources-2.6.15-r8 (and -r6 too), both 20060202 and 20060301 compile nicely and work. Could you try recent versions, please?
Comment 9 Alexandre Buisse (RETIRED) gentoo-dev 2006-03-22 10:34:15 UTC
Yes, both of these work fine without the patch, using the 2.6.16-rc* kernels.

Feel free to close.
Comment 10 Mike Doty (RETIRED) gentoo-dev 2006-04-14 08:57:55 UTC
looks like this is fixed