Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 116128 - Updated ebuild for net-proxy/dansguardian-2.9.3.1
Summary: Updated ebuild for net-proxy/dansguardian-2.9.3.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Gentoo Network Proxy Developers (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-19 23:58 UTC by Natanael Copa
Modified: 2005-12-20 05:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
dansguardian-2.9.3.1.ebuild (dansguardian-2.9.3.1.ebuild,2.66 KB, text/plain)
2005-12-19 23:59 UTC, Natanael Copa
Details
files/dansguardian-2.9.3.1-gentoo.patch (dansguardian-2.9.3.1-gentoo.patch,444 bytes, patch)
2005-12-20 00:03 UTC, Natanael Copa
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Natanael Copa 2005-12-19 23:58:00 UTC
Dansguardian 2.9.3.1 is out and 2.9.3.0_alpha is in portage.
Comment 1 Natanael Copa 2005-12-19 23:59:25 UTC
Created attachment 75173 [details]
dansguardian-2.9.3.1.ebuild 

its just a rename of dansguardian-2.9.3.0_alpha.ebuild
Comment 2 Natanael Copa 2005-12-20 00:03:30 UTC
Created attachment 75174 [details, diff]
files/dansguardian-2.9.3.1-gentoo.patch

Needed for the ebuild. I think this could have been solved with sed in the ebuild instead to ease future maintainance. Something like:

sed 's:/etc/rc.d/init.d/dansguardian:/etc/init.d/dansguardian:g' doc/dansguardian.8

It would be safe and no patches would be needed in future.
Comment 3 Alin Năstac (RETIRED) gentoo-dev 2005-12-20 02:22:30 UTC
files/dansguardian-2.9.3.0-gentoo.patch does a little more than proposed sed.
On the contrary, I think patching improve maintainability. In this way, the maintainer could easily detect when the patch is no longer necessary.
Comment 4 Natanael Copa 2005-12-20 02:31:39 UTC
(In reply to comment #3)
> files/dansguardian-2.9.3.0-gentoo.patch does a little more than proposed sed.

Oh... I didnt see the "restart" option. It is missing in https://bugs.gentoo.org/attachment.cgi?id=75174

> On the contrary, I think patching improve maintainability. In this way, the
> maintainer could easily detect when the patch is no longer necessary.

That is a good point.
Comment 5 Alin Năstac (RETIRED) gentoo-dev 2005-12-20 05:28:30 UTC
version bumped