Bug 115992 – rxvt-unicode needs to be update for modular X

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jory A. Pratt 2005-12-18 15:19:28 UTC]

update ebuild for modular X.

[Comment 1 Jory A. Pratt 2005-12-18 15:20:23 UTC]

Created attachment 75050 [details]
diff against current ebuild

[Comment 2 Jakub Moc (RETIRED) 2005-12-23 01:44:24 UTC]

*** Bug 116449 has been marked as a duplicate of this bug. ***

[Comment 3 Brenden Matthews 2005-12-23 10:09:54 UTC]

Created attachment 75399 [details, diff]
rxvt-unicode-5.9-r1.ebuild.patch

The ebuild that was already attached doesn't have the correct dependancies.  This one does.

[Comment 4 Jakub Moc (RETIRED) 2005-12-30 14:01:31 UTC]

*** Bug 117231 has been marked as a duplicate of this bug. ***

[Comment 5 Ryan Hill (RETIRED) 2005-12-30 14:11:48 UTC]

Created attachment 75824 [details, diff]
rxvt-unicode-modx.diff

proto goes in DEPEND, and i think you missed libXrendr.

i686-pc-linux-gnu-gcc -O2 -march=prescott -fomit-frame-pointer -pipe -fno-ident -g -ggdb -I/usr/include/freetype2    -Wl,-O1 -o rxvtc rxvtc.o rxvtdaemon.o fdpass.o -lXft  -lsupc++ -lXft -lXrender -lfontconfig -lfreetype -lz -lX11

[Comment 6 Mamoru KOMACHI (RETIRED) 2005-12-30 14:53:37 UTC]

I'll fix rxvt this evening but I'm not maintaining rxvt-unicode.
latexer, ciaranm: could you guys check and apply the patch for rxvt-unicode?

[Comment 7 Ciaran McCreesh 2005-12-30 14:57:09 UTC]

Has someone checked that 'emerge rxvt-unicode' off a clean stage3 works correctly with this patch?

[Comment 8 Ryan Hill (RETIRED) 2005-12-30 17:24:27 UTC]

Created attachment 75837 [details, diff]
rxvt-unicode-modx2.diff

yeah, no problems building it in a 2005-r1 stage 3 chroot.  if you want to go minimal, this patch will have rxvt-unicode only depend on libXft, libXpm and xproto, and just trust those pkgs to pull in the rest of the needed libraries.  this could suck if the deps btwn them ever change in the future but i don't know why they would.

[Comment 9 Jory A. Pratt 2005-12-31 09:37:04 UTC]

(In reply to comment #3)
> Created an attachment (id=75399) [edit]
> rxvt-unicode-5.9-r1.ebuild.patch
> 
> The ebuild that was already attached doesn't have the correct dependancies. 
> This one does.
> 

Your ebuild has alot of deps that are already gonna be pulled in via libXt. We do not need to depend on deps that are already gonna be installed via  another lib.

[Comment 10 Brenden Matthews 2005-12-31 09:44:37 UTC]

(In reply to comment #9)
> (In reply to comment #3)
> > Created an attachment (id=75399) [edit]
> > rxvt-unicode-5.9-r1.ebuild.patch
> > 
> > The ebuild that was already attached doesn't have the correct dependancies. 
> > This one does.
> > 
> 
> Your ebuild has alot of deps that are already gonna be pulled in via libXt. We
> do not need to depend on deps that are already gonna be installed via  another
> lib.
> 

Feel free to prove me wrong, but I'm not seeing the right dependancies in libXt.  libXt has:

RDEPEND="x11-libs/libX11
    x11-libs/libSM
    x11-proto/xproto"
DEPEND="${RDEPEND}"

libSM has:

RDEPEND="x11-libs/libICE
    x11-libs/xtrans
    x11-proto/xproto"
DEPEND="${RDEPEND}"

libICE has:

RDEPEND="x11-libs/xtrans
    x11-proto/xproto"
DEPEND="${RDEPEND}"

So, from what I see the only one thats redundant is x11-proto/xproto, and maybe Xlib.

..then again I'm new to this whole modular build thing.

[Comment 11 Brenden Matthews 2005-12-31 09:48:04 UTC]

(In reply to comment #5)
> Created an attachment (id=75824) [edit]
> rxvt-unicode-modx.diff
> 
> proto goes in DEPEND, and i think you missed libXrendr.
> 
> i686-pc-linux-gnu-gcc -O2 -march=prescott -fomit-frame-pointer -pipe -fno-ident
> -g -ggdb -I/usr/include/freetype2    -Wl,-O1 -o rxvtc rxvtc.o rxvtdaemon.o
> fdpass.o -lXft  -lsupc++ -lXft -lXrender -lfontconfig -lfreetype -lz -lX11
> 

libXrender is pulled by libXft

[Comment 12 Brenden Matthews 2005-12-31 09:51:38 UTC]

The patch from comment 8 seems to be "the one" (as long as the deps for its deps don't change).

[Comment 13 Ciaran McCreesh 2005-12-31 10:50:36 UTC]

Omitting real direct dependencies that just happen to be pulled in currently by another ebuild isn't a very good idea. When the next version of said ebuild comes out with different deps, it'll break anything relying upon indirect dependencies. Instead you should list everything that the package needs directly, and leave out anything that's just required as a dependency of a dependency.

[Comment 14 Ryan Hill (RETIRED) 2005-12-31 13:58:31 UTC]

then attachment #75824 [details, diff] should cover your ass. ;)

[Comment 15 Mamoru KOMACHI (RETIRED) 2006-01-02 12:09:16 UTC]

Updated rxvt for modular X.

[Comment 16 Ciaran McCreesh 2006-01-02 23:30:34 UTC]

Ok, rxvt-unicode 6.2 has modular X deps, thanks.