installing git-0.99.9m on uclibc gentoo fails (Portage 2.0.51.22-r3 (uclibc/x86/hardened, gcc-3.3.6, uclibc-0.9.27-r0, 2.6.14-hardened i686) ) ... i686-pc-linux-uclibc-gcc -o get-tar-commit-id.o -c -march=pentium3 -O2 -pipe -fomit-frame-pointer -msse -mmmx -Wall -DSHA1_HEADER='<openssl/sha.h>' get-tar-commit-id.c i686-pc-linux-uclibc-gcc -o mailinfo.o -c -march=pentium3 -O2 -pipe -fomit-frame-pointer -msse -mmmx -Wall -DSHA1_HEADER='<openssl/sha.h>' mailinfo.c i686-pc-linux-uclibc-gcc -o mailsplit.o -c -march=pentium3 -O2 -pipe -fomit-frame-pointer -msse -mmmx -Wall -DSHA1_HEADER='<openssl/sha.h>' mailsplit.c mailinfo.c:10:19: iconv.h: No such file or directory i686-pc-linux-uclibc-gcc -o stripspace.o -c -march=pentium3 -O2 -pipe -fomit-frame-pointer -msse -mmmx -Wall -DSHA1_HEADER='<openssl/sha.h>' stripspace.c i686-pc-linux-uclibc-gcc -o daemon.o -c -march=pentium3 -O2 -pipe -fomit-frame-pointer -msse -mmmx -Wall -DSHA1_HEADER='<openssl/sha.h>' daemon.c mailinfo.c: In function `convert_to_utf8': mailinfo.c:447: error: `iconv_t' undeclared (first use in this function) mailinfo.c:447: error: (Each undeclared identifier is reported only once mailinfo.c:447: error: for each function it appears in.) mailinfo.c:447: error: syntax error before "conv" mailinfo.c:449: error: `conv' undeclared (first use in this function) mailinfo.c:468: warning: implicit declaration of function `iconv' mailinfo.c:469: warning: implicit declaration of function `iconv_close' make: *** [mailinfo.o] Error 1 make: *** Waiting for unfinished jobs....
Quick change of platform in bugzilla. Sorry about the email.
this is because the git package no longer has optional support for iconv it'll need to be patched to have a make option like the other features for NLS support
Created attachment 74955 [details, diff] (dirty ?) fix for the ivconv issue Basically I just removed the offending lines, builds and works for now with some basic git usage. But i don't know if that's the right fix, might be borked somewhere...
That patch will break git-mailinfo. Try adding: elibc_uclibc? ( dev-libs/libiconv ) to DEPEND in git-0.99.9n.ebuild. SpanKY, is that a bad solution ? Cheers, Ferdy
Created attachment 74962 [details, diff] iconv issue dirty fix updated after using a few more neurons ... Fernando : localization don't work properly on uclibc ( see bug #104237) adding a dependency to dev-libs/libiconv will only add more trouble. I don't think this patch will break git-mailinfo, it will just don't do charset convertion, but yes this might be seen as a bug...
I see, then I won't add such depend. I'm sorry but I'm not happy with that patch. I'm afraid you'll have to come with a better solution. Cheers, Ferdy
a dirty fix is pointless ... we want something to send to the git maintainers iconv is part of uClibc itself but is disabled by default since it isnt quite stable yet ... so yes, trying to use the iconv package wont work better to add a patch that'd be like Makefile: ifeq ($(NO_ICONV),YesPlease) CFLAGS += -DNO_ICONV endif mailinfo.c: #ifndef NO_ICONV #include <iconv.h> #endif ... static void convert_to_utf8(char *line, char *charset) { #ifndef NO_ICONV ... #endif }
Does this work as expected ? Or is the solution in comment #4 better now bug #104237 has been fixed ? I'll send it upstream if it's still sensible. Cheers, Ferdy
Created attachment 79840 [details, diff] git-no-iconv.diff Patch to remove iconv dependency from Git
patch looks great; please send upstream/add to portage and all that jazz :)
Since upstream is really active and they have that patch now, I'll resolve this one as UPSTREAM and wait until Junio releases a new version. If somehow the patch is rejected I'll add it locally to Gentoo. Thanks guys, Ferdy
Just, FYI Junio applied the patch some minutes ago, so it should be there in 1.2.2 Cheers, Ferdy
