The attached patch makes games eclass use the new function in portability eclass to check if a given user has login disabled (it checks for /usr/bin/false and (/usr)/sbin/nologin), and get rid of ${USERLAND} check for giving instructions about adding a group to the use, instead it uses ${CHOST}. Finally it uses -0 instead of --null as xargs from bsd does not support long options. HTH, Diego
Created attachment 74755 [details, diff] Eclass patch
why cant the CHOST just be a generic bsd match ... i imagine you bsd slackers all just copy from each other for user management
No, if you look at eutils and portability you'll see that NetBSD and OpenBSD does not use pw at all.
games herd? :)
Well, is-login-disabled is in the eutils or portability eclass? Also, you never answered SpanKY's question.
Which SpanKY question? the one in comment #2 is answered in #3. And the function has to be get through eutils (although it's in portability) because of the interdependency of functions that cannot be moved.
OK... it all looks good to me, then... guys?
Knock, knock?
i added the first and last hunks ... the middle hunk is wrong
Why it's wrong? the is-login-disabled function from portability works as intended, or there's something else?
instead of narrowing in on pieces of code, why dont you look at the surrounding bits in the 2nd hunk
Considering fixed, that part of the code is no use to us anyway, seems like more a workaround for old created games user/group. At the very least, it will be fixed for good when a better implementation for user/group access is in place.
