Bug 115527 – QA Violation: dev-lang/sr

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Seemant Kulleen (RETIRED) 2005-12-14 06:15:24 UTC]

Please *NEVER* EVER EVER *EVER* _*EVER*_ use sed/awk/echo in the global scope in
ebuilds.  For version munging, use the versionator eclass. This is a diff, which
does exactly what your awk statement does, but cleanly and without violating
ebuild QA:

Index: sr-2.3.3.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/dev-lang/sr/sr-2.3.3.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 sr-2.3.3.ebuild
--- sr-2.3.3.ebuild     16 Jul 2005 12:37:18 -0000      1.1
+++ sr-2.3.3.ebuild     14 Dec 2005 14:07:07 -0000
@@ -2,12 +2,12 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/dev-lang/sr/sr-2.3.3.ebuild,v 1.1 2005/07/16
12:37:18 griffon26 Exp $
 
-inherit eutils
+inherit versionator eutils
 
-My_PV="`echo ${PV} | awk -F. '{ gsub(/_pre.*|_alpha.*/, ""); print $1 $2 $3}'`"
+MY_P=${PN}$(delete_all_version_separators `get_version_component_range 1-3`)
 DESCRIPTION="SR (Synchronizing Resources) is a language for writing concurrent
programs"
 HOMEPAGE="http://www.cs.arizona.edu/sr"
-SRC_URI="ftp://ftp.cs.arizona.edu/sr/${PN}${My_PV}.tar.Z"
+SRC_URI="ftp://ftp.cs.arizona.edu/sr/${MY_P}.tar.Z"
 
 LICENSE="GPL-2"
 SLOT="0"

[Comment 1 Maurice van der Pot (RETIRED) 2005-12-14 06:45:13 UTC]

You're right of course. I should've paid closer attention.

Fixed in CVS.