Bug 115503 – dev-perl/perl: -fno-stack-protector patch should check for compiler support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2005-12-14 00:26:17 UTC]

[CCing osx as this drops an userland_Darwin check, they should like that ;)] 
 
For a mistake I tried to build perl with a GCC compiled with +vanilla 
useflag.. the result was not good, as it tries to use -fno-stack-protector 
flag that does not work with that. Currently the patch that adds the 
-fno-stack-protector calls is applied conditionally to userland_Darwin, that 
is not a good way to apply a patch. 
 
The attached patch instead change the ebuild to check with test-flags if the 
-fno-stack-protector flag is supported instead, not adding the flag when the 
compiler does not support it. 
 
IMHO the patch should be applied to the entire 5.8.7 series to make the 
userland_Darwin go away from there, but that's up to perl herd :) 
 
Thanks, 
Diego

[Comment 1 Diego Elio Pettenò (RETIRED) 2005-12-14 00:26:35 UTC]

Created attachment 74690 [details, diff]
perl-5.8.7-ebuilds.patch

[Comment 2 Fabian Groffen 2005-12-14 02:45:49 UTC]

patch looks good.  If it still works, then I'm very happy with the change.

[Comment 3 Michael Cummings (RETIRED) 2005-12-14 03:18:22 UTC]

committed