Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 114788 - gst-plugins-cdparanoia-0.8.10 crashes applications if /dev/sg* device is not readable
Summary: gst-plugins-cdparanoia-0.8.10 crashes applications if /dev/sg* device is not ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal
Assignee: GStreamer package maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-07 11:59 UTC by Philippe Troin
Modified: 2006-02-06 22:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Troin 2005-12-07 11:59:15 UTC 
% ll /dev/sr0 /dev/sg0
crw-rw----  1 root cdrom 21, 0 Dec  7 10:58 /dev/sg0
brw-rw----  1 root root  11, 0 Dec  7 10:39 /dev/sr0

(/dev/sg0 is the sg device for /dev/sr0)

Put an audio CD in the drive, run for example gnome-cd, and press play.
Watch it crash.


Reproducible: Always
Steps to Reproduce:
The bug comes from these lines in
gst-plugins-0.8.10/ext/cdparanoia/gstcdparanoia.c around line 790:

  /* fail if the device couldn't be found */
  if (src->d == NULL) {
    GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ,
        (_("Could not open CD device %s for reading."),
            src->d->cdda_device_name), ("cdda_identify failed"));
    return FALSE;
  }

src->d is deferenced in the if clause testing is src->d is NULL.

Boo!
Comment 1 Zaheer Abbas Merali (RETIRED) gentoo-dev 2006-02-06 22:57:52 UTC 
this is fixed in 0.8.11 please update.