Bug 114473 – xmms-mad-0.8 header detection fix

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Heikki Orsila 2005-12-04 13:30:30 UTC]

xmms-mad-0.8 mp3 header detection is broken. It detects all files which begin
with 0xffffffff as mp3s, but it is wrong and creates conflict with Amiga
Activision Pro music format used with UADE. Here's a patch that is taken from
xmms mp3 input plugin that fixes the header detection problem.

Please replace the current mp3 header patch with this one.

[Comment 1 Heikki Orsila 2005-12-04 13:31:00 UTC]

Created attachment 74061 [details, diff]
xmms-mad-0.8 mp3 header fix

[Comment 2 Heikki Orsila 2005-12-04 13:36:17 UTC]

Created attachment 74062 [details, diff]
xmms-mad-0.8 mp3 header detection fix again

[Comment 3 Heikki Orsila 2005-12-04 13:36:49 UTC]

Comment on attachment 74062 [details, diff]
xmms-mad-0.8 mp3 header detection fix again

Forgot to declare the new function as static. Fixed now.

[Comment 4 Heikki Orsila 2005-12-05 06:19:06 UTC]

Sam Clegg emailed me that this change will be merged to a next version of
xmms-mad. I don't know when it is released.

[Comment 5 Luis Medinas (RETIRED) 2005-12-05 14:32:10 UTC]

yes this patch looks better than the older one... it's in cvs.
Thanks

[Comment 6 Heikki Orsila 2005-12-05 14:43:00 UTC]

(In reply to comment #5)
> yes this patch looks better than the older one... it's in cvs.
> Thanks

It is possible, but not certain, that Sam will do a new release with later this
week. It would be nice to not have to patch this plugin at all:)