Bug 113590 – VLC 0.8.4beta3 Compilation Problem (gcc3.4.4)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Markus Kohls 2005-11-25 14:30:43 UTC]

if i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../..   -DSYS_LINUX 
-I../../include `top_builddir="../.." ../../vlc-config --cflags builtin pic 
i420_rgb_mmx` -Wsign-compare -Wall -O2 -march=athlon-xp -fomit-frame-pointer 
-pipe -pipe -MT libi420_rgb_mmx_pic_a-i420_rgb16.o -MD -MP -MF 
".deps/libi420_rgb_mmx_pic_a-i420_rgb16.Tpo" -c -o 
libi420_rgb_mmx_pic_a-i420_rgb16.o `test -f 'i420_rgb16.c' || echo 
'./'`i420_rgb16.c; \ 
then mv -f ".deps/libi420_rgb_mmx_pic_a-i420_rgb16.Tpo" 
".deps/libi420_rgb_mmx_pic_a-i420_rgb16.Po"; else rm -f 
".deps/libi420_rgb_mmx_pic_a-i420_rgb16.Tpo"; exit 1; fi 
i420_rgb16.c: In function `I420_RGB16__i420_rgb_mmx': 
i420_rgb16.c:346: error: `__m64' undeclared (first use in this function) 
i420_rgb16.c:346: error: (Each undeclared identifier is reported only once 
i420_rgb16.c:346: error: for each function it appears in.) 
i420_rgb16.c:346: error: parse error before "mm0" 
i420_rgb16.c:347: warning: unused variable `tmp64' 
i420_rgb16.c: In function `I420_RGB32__i420_rgb_mmx': 
i420_rgb16.c:532: error: `__m64' undeclared (first use in this function) 
i420_rgb16.c:532: error: parse error before "mm0" 
i420_rgb16.c:533: warning: unused variable `tmp64' 
make[4]: *** [libi420_rgb_mmx_pic_a-i420_rgb16.o] Error 1 
make[4]: Leaving directory 
`/var/tmp/portage/vlc-0.8.4_beta3/work/vlc-0.8.4-test3/modules/video_chroma' 
make[3]: *** [all-modules] Error 1 
make[3]: Leaving directory 
`/var/tmp/portage/vlc-0.8.4_beta3/work/vlc-0.8.4-test3/modules/video_chroma' 
make[2]: *** [all-recursive] Error 1 
make[2]: Leaving directory 
`/var/tmp/portage/vlc-0.8.4_beta3/work/vlc-0.8.4-test3/modules' 
make[1]: *** [all-recursive] Error 1 
make[1]: Leaving directory 
`/var/tmp/portage/vlc-0.8.4_beta3/work/vlc-0.8.4-test3' 
make: *** [all] Error 2 
 
I get this compile error in chroma_plugin with gcc 3.4.4 

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Gergan Penkov 2005-11-26 06:04:24 UTC]

This occur only when the mozilla-plugin is selected. The problem is that in this
case this file builds with -fpic, which in turn shows the deep mess in the
preprocessor directives. I've commented here
http://forum.videolan.org/viewtopic.php?p=44047#44047 first, because there was
no bugreport on gentoo and I was trying to build with mozilla and not gecko-sdk
(I'll open a different bugreport about this). I'm not completely sure if the
patch, which I posted there and will upload here, will work 100%, but its logic
is the same as in the other functions in the file and I don't have problems with it.

[Comment 2 Gergan Penkov 2005-11-26 06:05:22 UTC]

Created attachment 73633 [details, diff]
vlc-pic.patch

patch to correct the pic mess

[Comment 3 Diego Elio Pettenò (RETIRED) 2005-11-27 04:55:31 UTC]

Make sense, I'll merge it into the current patch for 0.8.4 release. Thanks for 
reporting. 
 

[Comment 4 Diego Elio Pettenò (RETIRED) 2005-11-27 07:55:08 UTC]

Fixed in 0.8.4 final.