Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 113441 - Patch for devil-1.6.7 to honour sdl USE flag
Summary: Patch for devil-1.6.7 to honour sdl USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-24 02:35 UTC by Henrik Dohlmann
Modified: 2005-11-25 11:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for devil to honour --disable-sdl configure option (devil-1.6.7-configure.in.patch,413 bytes, patch)
2005-11-24 02:41 UTC, Henrik Dohlmann
Details | Diff
patch for devil-1.6.7-r1.ebuild to apply configure.in patch (ebuild.patch,611 bytes, patch)
2005-11-24 02:49 UTC, Henrik Dohlmann
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Dohlmann 2005-11-24 02:35:43 UTC
The configure.in file fails to honour --disable-sdl, whereby sdl is always 
linked in when using devil. 

Reproducible: Always
Steps to Reproduce:
1. cat "media-libs/devil -sdl" >> /etc/portage/package.use 
2. emerge -av devil 
3. less /usr/lib/libILUT.la 
 
Actual Results:  
dependency_libs contains /usr/lib/libSDL.la 

Expected Results:  
dependency_libs should have no reference to anything sdl. 

palle devil # emerge info 
Portage 2.0.51.22-r3 (default-linux/x86/2005.1, gcc-3.4.4, glibc-2.3.5-r2, 
2.6.14-gentoo-r2 i686) 
================================================================= 
System uname: 2.6.14-gentoo-r2 i686 Intel(R) Pentium(R) 4 CPU 2.40GHz 
Gentoo Base System version 1.6.13 
ccache version 2.3 [enabled] 
dev-lang/python:     2.3.5-r2, 2.4.2 
sys-apps/sandbox:    1.2.12 
sys-devel/autoconf:  2.13, 2.59-r6 
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1 
sys-devel/binutils:  2.15.92.0.2-r10 
sys-devel/libtool:   1.5.20 
virtual/os-headers:  2.6.11-r2 
ACCEPT_KEYWORDS="x86" 
AUTOCLEAN="yes" 
CBUILD="i686-pc-linux-gnu" 
CFLAGS="-march=pentium4 -O3 -pipe -fomit-frame-pointer -fforce-addr -ftracer 
-funit-at-a-time" 
CHOST="i686-pc-linux-gnu" 
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control" 
CONFIG_PROTECT_MASK="/etc/gconf /etc/splash /etc/terminfo /etc/env.d" 
CXXFLAGS="-march=pentium4 -O3 -pipe -fomit-frame-pointer -fforce-addr -ftracer 
-funit-at-a-time -fvisibility-inlines-hidden" 
DISTDIR="/usr/portage/distfiles" 
FEATURES="autoconfig candy ccache distlocks fixpackages sandbox sfperms 
strict" 
GENTOO_MIRRORS="ftp://ftp.gentoo.diku.dk/ http://www.ibiblio.org/gentoo/ 
ftp://gentoo.linux.no/pub/gentoo/ http://gentoo.linux.no/" 
LC_ALL="en_US.utf8" 
MAKEOPTS="-j2" 
PKGDIR="/usr/portage/packages" 
PORTAGE_TMPDIR="/var/tmp" 
PORTDIR="/usr/portage" 
PORTDIR_OVERLAY="/usr/local/portage" 
SYNC="rsync://rsync.gentoo.diku.dk/gentoo-portage" 
USE="x86 X Xaw3d acl acpi alsa arts atlas audiofile avi berkdb bitmap-fonts 
bzip2 bzlib cdr crypt cups curl dga divx4linux eds emacs emboss encode esd 
exif expat fam ffmpeg fftw flac foomaticdb fortran gd gdbm gif gimpprint glut 
gpm gstreamer gtk gtk2 hal idn imagemagick imlib jai java jikes jimi jpeg 
junit kde kdeenablefinal lcms leim libg++ libwww live lzw-tiff mad maildir 
mhash mikmod mmap mmx mng motif mp3 mpeg nas ncurses network nls nptl nptlonly 
ogg oggvorbis openexr opengl pam pcre pda pdflib perl pic png ppds python qt 
quicktime readline real sdl slang spell sse sse2 ssl subversion svg svga tcpd 
tetex tiff truetype truetype-fonts type1-fonts udev unicode userlocales vorbis 
xine xml2 xmms xv xvid zlib userland_GNU kernel_linux elibc_glibc" 
Unset:  ASFLAGS, CTARGET, LANG, LDFLAGS, LINGUAS
Comment 1 Henrik Dohlmann 2005-11-24 02:41:44 UTC
Created attachment 73482 [details, diff]
patch for devil to honour --disable-sdl configure option

This patch requires autoconf to be run before configuring. See patch to ebuild.
Comment 2 Henrik Dohlmann 2005-11-24 02:49:42 UTC
Created attachment 73484 [details, diff]
patch for devil-1.6.7-r1.ebuild to apply configure.in patch

The patch to configure.in requires that autoconf is run afterwards.
I inherit autotools and run eautoconf.
This works, but I get warnings about illegally inheriting autotools and
gnu_autoconf.
I don't know what to do instead...
Comment 3 SpanKY gentoo-dev 2005-11-24 12:08:12 UTC
have you submitted this patch upstream ?
Comment 4 Henrik Dohlmann 2005-11-24 14:30:15 UTC
(In reply to comment #3)
> have you submitted this patch upstream ?

Nopes. Should I do this first?
Comment 5 SpanKY gentoo-dev 2005-11-24 23:23:50 UTC
you should do it now while we add it to portage
Comment 6 Henrik Dohlmann 2005-11-25 00:55:00 UTC
I have submitted the configure.in patch to: 
https://sourceforge.net/tracker/?group_id=4470&atid=304470. 
Comment 7 SpanKY gentoo-dev 2005-11-25 11:11:11 UTC
added to portage, thanks