Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 113431 - baselayout-1.12.0_pre11 does not repopulate ppp secrets files
Summary: baselayout-1.12.0_pre11 does not repopulate ppp secrets files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: x86 Linux
: High minor (vote)
Assignee: Roy Marples (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-23 23:09 UTC by Paul Bredbury
Modified: 2005-11-28 03:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
pppd.patch (pppd.patch,478 bytes, patch)
2005-11-24 00:44 UTC, Alin Năstac (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Bredbury 2005-11-23 23:09:53 UTC 
The pppd_update_secrets_file() function in /lib/rcscripts/net.modules.d/pppd
fails to repopulate a non-existent {chap,pap}-secrets file in /etc/ppp/. The
file is created by "touch", but not populated with the username and password by
"sed".

The problem is the regular-expression voodoo in that function :)
Comment 1 Roy Marples (RETIRED) gentoo-dev 2005-11-23 23:47:42 UTC 
Your voodoo mrness
Comment 2 Alin Năstac (RETIRED) gentoo-dev 2005-11-24 00:44:30 UTC 
Created attachment 73479 [details, diff]
pppd.patch

Yes, that sed cannot handle empty files.

This pppd patch fixes that.
Comment 3 Roy Marples (RETIRED) gentoo-dev 2005-11-24 04:27:29 UTC 
Patch is in our svn repo - will be in baselayout-1.12.0_pre12
Comment 4 Roy Marples (RETIRED) gentoo-dev 2005-11-28 03:04:14 UTC 
Fixed in pre11-r2