113379 – sysfs-/udev path_id defaults to PCI in handle_block_scsi()

Bug 113379 - sysfs-/udev path_id defaults to PCI in handle_block_scsi()

Summary: sysfs-/udev path_id defaults to PCI in handle_block_scsi()

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Unspecified (show other bugs)
Hardware:	HPPA Linux

Importance:	High trivial (vote)
Assignee:	Greg Kroah-Hartman (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-11-23 11:14 UTC by Jeroen Roovers (RETIRED)
Modified:	2006-01-30 13:47 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
udev-path_id-parisc.patch (udev-path_id-parisc.patch,461 bytes, patch) 2005-11-23 11:15 UTC, Jeroen Roovers (RETIRED)	Details \| Diff
Fix the speeling error in path_id (sys-fs/udev-079) :) (udev-path_id-parisc-2.patch,268 bytes, patch) 2005-12-26 23:48 UTC, Jeroen Roovers (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jeroen Roovers (RETIRED) gentoo-dev

2005-11-23 11:14:04 UTC

path_id harcodes a pci- for every case except Oldworld Macs, whereas on some 
PARISC systems, the SCSI controller might be on the GSC or some other 
proprietary bus. The patch I provide was written for udev-070-r1 but still 
applies neatly to udev-073.

In future, it might be better to not harcode "pci" at all but somehow scan /sys/
bus/scsi/devices/ instead of /sys/devices/ in handle_block_scsi().

With a generic solution, udev wouldn't write (possibly confusing) pci-* entries 
into /dev/disk/by-path/ on systems that have no PCI bus.

Comment 1 Jeroen Roovers (RETIRED) gentoo-dev

2005-11-23 11:15:27 UTC

Created attachment 73447 [details, diff]
udev-path_id-parisc.patch

Scans and harcodes PARISC-specific prefix for SCSI block devices.

Comment 2 Jeroen Roovers (RETIRED) gentoo-dev

2005-11-23 11:41:56 UTC

Example of a block device on a SCSI controller on the GSC bus on an HP/9000 
Visualize B160L:

hpvis ~ # ls -ld /sys/block/sda/device
lrwxrwxrwx  1 root root 0 Nov 23 19:46 /sys/block/sda/device -> ../../devices/
parisc/8/8:12/host0/target0:0:6/0:0:6:0

Comment 3 Greg Kroah-Hartman (RETIRED) gentoo-dev

2005-12-07 13:47:44 UTC

Will be fixed in 077-r1 release, thanks.

Comment 4 Jeroen Roovers (RETIRED) gentoo-dev

2005-12-26 23:48:34 UTC

Created attachment 75585 [details, diff]
Fix the speeling error in path_id (sys-fs/udev-079) :)

[Before]

hpvis ~ # ls /dev/disk/by-path/
parisc--scsi-0:0:6:0        parisc--scsi-0:0:6:0-part3
parisc--scsi-0:0:6:0-part1  parisc--scsi-0:0:6:0-part4
parisc--scsi-0:0:6:0-part2
hpvis ~ # rm /dev/disk/by-path/*; udevstart

[After]

hpvis ~ # ls /dev/disk/by-path/
parisc-8:12-scsi-0:0:6:0        parisc-8:12-scsi-0:0:6:0-part3
parisc-8:12-scsi-0:0:6:0-part1  parisc-8:12-scsi-0:0:6:0-part4
parisc-8:12-scsi-0:0:6:0-part2

Comment 5 Jeroen Roovers (RETIRED) gentoo-dev

2005-12-26 23:53:18 UTC

For reason mentioned above.

Comment 6 Greg Kroah-Hartman (RETIRED) gentoo-dev

2006-01-30 13:47:25 UTC

Ok, will be fixed in 083, sorry about that.