Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 112723 - mplayer-1.0_pre7-r1: 'configure' should be patched for proper fribidi support
Summary: mplayer-1.0_pre7-r1: 'configure' should be patched for proper fribidi support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
: 258765 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-11-16 11:06 UTC by Yoel Jacobsen
Modified: 2009-08-03 20:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yoel Jacobsen 2005-11-16 11:06:03 UTC
In order for the USE flag 'bidi' to take effect, the 'configure' script need to
be patched as follows: 
Line 5010:
Original:
  if(fribidi_parse_charset("UTF-8") != FRIBIDI_CHARSET_UTF8) {
Patched:
  if(fribidi_parse_charset("UTF-8") != FRIBIDI_CHAR_SET_UTF8) {


Reproducible: Always
Steps to Reproduce:
1.emerge mplayer
2.mplayer -flip-hebrew
3.

Actual Results:  
Error: MPlayer was compiled without FriBiDi support.


Expected Results:  
fribidi support compiled in
Comment 1 Steve Dibb (RETIRED) gentoo-dev 2006-06-22 17:24:37 UTC
Looks like its fixed in pre8 -- reopen if still having problems

Thanks, Yoel
Comment 2 Yoel Jacobsen 2009-01-26 19:05:35 UTC
It is happening again:
yoel ~ # equery uses mplayer
.....
 + + bidi                : Enables bidirectional language support
yoel ~ # mplayer -flip-hebrew
MPlayer dev-SVN-r28288-4.3.2 (C) 2000-2009 MPlayer Team
CPU: Intel(R) Pentium(R) M processor 2.00GHz (Family: 6, Model: 13, Stepping: 6)
CPUflags:  MMX: 1 MMX2: 1 3DNow: 0 3DNow2: 0 SSE: 1 SSE2: 1
Compiled for x86 CPU with extensions: MMX MMX2 SSE SSE2
MPlayer was compiled without FriBiDi support.
Comment 3 Yoel Jacobsen 2009-01-26 19:06:51 UTC
Version is: media-video/mplayer-1.0_rc2_p28288 

Should I reopen as a new bug?
Comment 4 Steve Dibb (RETIRED) gentoo-dev 2009-02-26 20:37:30 UTC
(In reply to comment #3)
> Version is: media-video/mplayer-1.0_rc2_p28288 
> 
> Should I reopen as a new bug?
> 

It looks like it got committed upstream sometime between now and then, it's certainly working for me.

Can you test on mplayer-20090226.28734 and confirm?

Thanks
Comment 5 Steve Dibb (RETIRED) gentoo-dev 2009-02-26 20:38:05 UTC
*** Bug 258765 has been marked as a duplicate of this bug. ***
Comment 6 Roby 2009-04-03 16:12:12 UTC
The patch works for me.
Comment 7 Yoel Jacobsen 2009-05-07 12:11:43 UTC
The bug seems to still be in effect with mplayer-1.0_rc2_p20090322
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2009-08-03 20:44:05 UTC
nique mplayer-1.0_rc2_p20090731 # grep FRIBIDI configure
#define FRIBIDI_CHARSET_UTF8 FRIBIDI_CHAR_SET_UTF8
    if (fribidi_parse_charset("UTF-8") != FRIBIDI_CHAR_SET_UTF8) {
    def_fribidi='#define CONFIG_FRIBIDI'
    def_fribidi='#undef CONFIG_FRIBIDI'

Looks like this is fixed in 20090731.