Bug 11222 – needless sed hack in webalizer ebuild

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jukka Salmi 2002-11-25 16:23:34 UTC]

app-admin/webalizer's ebuild function 'src_unpack()' uses sed to change a
#include in a source file (line 25 ff.) because db1 headers are in
/usr/include/db1 by default. you could add '--with-db=/usr/include/db1' to the
econf arguments in function 'src_compile()' instead. what an enhancement ;-)

greetings, jukka


diff of the ebuild would be:

 src_unpack() {
        unpack ${A} ; cd ${S}
-       # fix --enable-dns; our db1 headers are in /usr/include/db1
-       mv dns_resolv.c dns_resolv.c.orig
-       sed -e 's%^\(#include \)\(<db.h>\)\(.*\)%\1<db1/db.h>\3%' \
-               dns_resolv.c.orig > dns_resolv.c
 }
 
 src_compile() {
        econf \
                --enable-dns \
+               --with-db=/usr/include/db1 \
                --with-etcdir=/etc/apache/conf || die
        make || die
 }

[Comment 1 Donny Davies (RETIRED) 2002-11-26 22:04:27 UTC]

so this makes absolutely no difference in the end product?

gee i guess ill just RUSH to fix this then.

[Comment 2 Jukka Salmi 2002-11-27 08:46:53 UTC]

yes. go ahead ;-)