Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 111765 - bash-completion incorrect for evince
Summary: bash-completion incorrect for evince
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-06 23:52 UTC by Ed Catmur
Modified: 2006-03-02 04:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
111765-evince-completion-ps-dvi.bugs.gentoo.org.patch (111765-evince-completion-ps-dvi.bugs.gentoo.org.patch,773 bytes, patch)
2005-11-06 23:55 UTC, Ed Catmur 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Catmur 2005-11-06 23:52:41 UTC 
The bash-completion for evince (in bash-completion-20050721) is:

    complete -f -X '!*.@(pdf|PDF)' acroread gpdf xpdf kpdf evince

This is insufficient, as evince can also open (e)ps and dvi files.

It should be changed to:

    complete -f -X '!*.@(pdf|PDF)' acroread gpdf xpdf kpdf
    complete -f -X '!*.@(pdf|PDF|?(e)ps|?(E)PS|dvi|DVI)' evince

I will attach a patch.
Comment 1 Ed Catmur 2005-11-06 23:55:01 UTC 
Created attachment 72356 [details, diff]
111765-evince-completion-ps-dvi.bugs.gentoo.org.patch

As above.

Should I upstream this patch?
Comment 2 Aaron Walker (RETIRED) gentoo-dev 2005-11-07 04:54:59 UTC 
> Should I upstream this patch?

Would be most awesome if you did.  I'm in the process of moving atm so I
probably won't get to this (and the other bashcomp bugs) for a week or two.
Comment 3 Ed Catmur 2005-11-08 02:57:15 UTC 
OK, have emailed upstream. Will post back when I hear back.
Comment 4 Aaron Walker (RETIRED) gentoo-dev 2006-03-02 04:03:50 UTC 
Looks like upstream added it.  20060301 is in portage.  Thanks.