add in "USE" for select image library Reproducible: Always Steps to Reproduce: 1. 2. 3.
Created attachment 72333 [details, diff] qt-3.3.4-r8.ebuild.diff patch for qt-3.3.4-r8.ebuild
Created attachment 72334 [details, diff] qt-3.3.5.ebuild.diff patch for qt-3.3.5.ebuild.diff
I like the patch, but I think turning off these features will cause too many problems for users. Instead, perhaps it would be smarter to make the non-use flag people use the "-system-lib{png,jpeg,mng" options.
(In reply to comment #3) > I like the patch, but I think turning off these features will cause too many > problems for users. Instead, perhaps it would be smarter to make the non-use > flag people use the "-system-lib{png,jpeg,mng" options. Why? From a maintenance point of view (vulnerabilities etc.) and also for memory consumtion it makes sense to use shared libs only, whenever possible. I'd also prefer, if we'd hard depend on the system zlib. btw. there's also someone working on Tiff support for Qt: http://artis.imag.fr/Software/TiffIO/ Caleb, trying to crosslink a bit: you noticed the Qt 4.1 issue - bug 115691 ? And what's your opinion about unmasking Qt 3.3.5 and the other issues (don't know if you have much time looking at youremails lately).
> Why? From a maintenance point of view (vulnerabilities etc.) and also for I guess I should say I'm "indifferent" about the patch. I did this implementation for Qt4 mainly because of the notion that someday we'll be able to install it without having to install X, so it seemed logical to also be able to turn off these shared libraries. For Qt3, however, I suppose that we're far enough along now with its development not to really worry anymore...
> Caleb, trying to crosslink a bit: you noticed the Qt 4.1 issue - bug 115691 ? > And what's your opinion about unmasking Qt 3.3.5 and the other issues (don't > know if you have much time looking at youremails lately). I don't think I'm getting all of my mails (maybe they're getting trapped as spams on dev.g.o?), based on the comments from the bug you just mentioned. However, I'm okay for unmasking 3.3.5 as long as all the KDEs in portage play nicely with it.
(In reply to comment #6) > I don't think I'm getting all of my mails (maybe they're getting trapped as > spams on dev.g.o?), based on the comments from the bug you just mentioned. If you did not enable it, there should be no spam filtering happen. Do you want me to forward the latest emails directed at kde@gentoo.org to caleb@gentoo.org or elsewhere? > However, I'm okay for unmasking 3.3.5 as long as all the KDEs in portage play > nicely with it. Well, no one patched KDE 3.4... Since it is stable it should only an issue regarding creation and testing of security fixes, though.
Created attachment 86747 [details, diff] qt-3.3.6-r1.ebuild.diff Corrected and but suitable patch
(In reply to comment #8) > Created an attachment (id=86747) [edit] > qt-3.3.6-r1.ebuild.diff kghostview, kmahjongg, amarok and valkyrie work nicely with this patch, thanks. I don't use anything else that needs qt, so I can't comment on that. Just trying to give a little nudge away from "indifference" here. :-)
Qt 3 bugs are no longer getting solved.
