Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 111408 - want GTK2 support patch in MPlayer
Summary: want GTK2 support patch in MPlayer
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Media-video project
URL: http://linuxfromscratch.org/pipermail...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-03 14:11 UTC by Ryan Hendrickson
Modified: 2006-02-26 20:28 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
the patch for MPlayer to use the GTK2 libraries (gtk2_patch_20050530.diff,6.04 KB, patch)
2005-11-03 14:13 UTC, Ryan Hendrickson
Details | Diff
ebuild using the GTK2 patch iff gtk2 use-flag is set (mplayer-1.0_pre7-r2.ebuild,15.74 KB, text/plain)
2005-11-03 14:24 UTC, Ryan Hendrickson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Hendrickson 2005-11-03 14:11:15 UTC
There's a lovely little patch for MPlayer-1.0pre7 which I found at the cited URL
which enables GTK2 support.  I'm attaching the patch and a revised ebuild file
which I used to compile it in (with the gtk2 use-flag)—it works without
problems for me and I'm hoping it'll find its way into Portage!

Reproducible: Always
Steps to Reproduce:
Comment 1 Ryan Hendrickson 2005-11-03 14:13:22 UTC
Created attachment 72062 [details, diff]
the patch for MPlayer to use the GTK2 libraries

Found at http://linuxfromscratch.org/pipermail/patches/2005-May/002288.html
Comment 2 Ryan Hendrickson 2005-11-03 14:24:56 UTC
Created attachment 72063 [details]
ebuild using the GTK2 patch iff gtk2 use-flag is set

KEYWORDS="~x86" because I've only tested it on my one machine, but I don't see
why it wouldn't work everywhere.

Also, it may need to be tested more rigorously for dependencies; I just have
gtk2? ( >=x11-libs/gtk+-2 >=dev-libs/glib-2 )
but it's conceivable that the patch won't work for older versions of GTK2 or
assumes more than these two libraries, libpng, and X11.

But you wizardly folk probably have your own ideas on going about these things
so I'm going to stop telling you how to do your (volunteer) jobs.  Mad respect
to y'all.
Comment 3 Carsten Lohrke (RETIRED) gentoo-dev 2005-11-03 14:37:00 UTC
The gtk2 use flag is depracted. Gentoo defaults to Gtk2 when supported by
upstream, otherwise Gtk1.
Comment 4 Sascha Wintz 2005-11-03 18:06:11 UTC
Awesome! And it works find on AMD64, too :-)

[ebuild   R   ] media-video/mplayer-1.0_pre7-r1  (-3dfx) (-3dnow) (-3dnowext) +X
+aac +aalib +alsa (-altivec) -arts -bidi -bl +cdparanoia -cpudetection
-custom-cflags -debug -dga -directfb -doc +dts -dv -dvb +dvd +dvdread -edl
+encode -esd -fbcon -ggi +gif +gtk +gtk2 -i8x0 -ipv6 -jack +joystick +jpeg
-libcaca -lirc -live -lzo +mad +matroska -matrox (-mmx) (-mmxext) -mythtv -nas
+nls +nvidia +opengl -oss +png -real +rtc +samba +sdl (-sse) (-sse2) (-svga)
-tga +theora +truetype +v4l +v4l2 +vorbis (-win32codecs) -xanim +xinerama -xmms
+xv +xvid -xvmc 0 kB [1]
Comment 5 Giorgio Lando 2005-11-24 08:58:37 UTC
No problems here, and the gtk2 gmplayer is more stable and far more nice to see.
Moreover, mplayer was the only app in my system depending on gtk1 (with gtk USE
FLAG) and now I can get rid of that old piece of software.

Thanks! 

My emerge info output: 

Portage 2.0.53_rc7 (default-linux/x86/2005.0, gcc-3.4.4, glibc-2.3.5-r3,
2.6.14-gentoo-r2 i686)
=================================================================
System uname: 2.6.14-gentoo-r2 i686 mobile AMD Athlon(tm) XP 2000+
Gentoo Base System version 1.12.0_pre9
ccache version 2.4 [enabled]
dev-lang/python:     2.3.5, 2.4.2
sys-apps/sandbox:    1.2.13
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1
sys-devel/libtool:   1.5.20-r1
virtual/os-headers:  2.6.11-r3
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=athlon-xp -O3 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/share/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/splash /etc/terminfo /etc/texmf/web2c
/etc/env.d"
CXXFLAGS="-march=athlon-xp -O3 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://mirror.gentoo.gr.jp http://ftp.gentoo.or.kr/
http://gentoo.kems.net http://gentoo.channelx.biz/"
LANG="it_IT@euro"
LC_ALL="it_IT@euro"
LDFLAGS="-Wl,-O1"
LINGUAS="it"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="x86 3dnow 3dnowext X a52 accessibility acpi aim alsa amuled audiofile
authdaemond avi bash-completion berkdb bigger-fonts bitmap-fonts bootsplash
bzip2 cdb cdda cdr cdrom crypt cups dlloader dri dvd dvdr dvdread emacs emboss
encode escreen exif expat fam fbcon ffmpeg flac foomaticdb fortran freetype gd
gdbm gecko-sdk gif gimp glut gmail gnutls gpm gstreamer gtk gtk2 gtkhtml httpd
icq idn imagemagick imlib jabber java javascript jpeg justify latex ldap libg++
libwww lynxkeymap mad maildir mailwrapper mhash mikmod mjpeg mmx mmxext mng
motif mozilla mp3 mpeg mpeg2 mplayer msn multi-tty ncurses neXt nls nosendmail
nptl nsplugin ogg oggvorbis opengl oscar pcre pdflib perl png python quicktime
readline real remote rplay rtc sdl sftplogging slang spell sqlite sse
sse-filters ssl startup-notification stats stencil-buffer stroke svg svga
symlink tcltk tcpd tetex theora threads tiff truetype truetype-fonts type1-fonts
udev unicode usb vcd vlm vorbis win32codecs wmf wxwindows xanim xfs xml xml2
xosd xprint xrandr xv xvid yahoo zlib video_cards_radeon linguas_it userland_GNU
kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET
Comment 6 Sascha G. 2006-01-03 15:42:46 UTC
The new version of mplayer that is now in portage (mplayer-1.0.20060102) supports gtk2 by default. The ebuild wrongly claims a dependency on gtk1.
Comment 7 Xake 2006-01-24 06:51:29 UTC
With an reference to the last comment.
Could someone please fix the ebuilds dependency?

Currently mplayer is the only application on my system that want to pull gtk1 in, and since it does not need it with the cvs-snapshot it is somewhat annoying.
Comment 8 Miro Bogner 2006-01-26 09:28:42 UTC
I can't find a the executable for startup with gui. Where should it be and how is it supposed to be called?
Comment 9 Ryan Hendrickson 2006-01-26 09:33:07 UTC
(In reply to comment #8)
> I can't find a the executable for startup with gui. Where should it be and how
> is it supposed to be called?
> 

/usr/bin/gmplayer

(http://www.mplayerhq.hu/DOCS/HTML/en/gui.html for your RTFMing pleasure)
Comment 10 Miro Bogner 2006-01-26 10:21:17 UTC
okay problem was that I builded with -gtk and gtk2.. gui is builed only with gtk AND gtk2 USE FLAGS..
Comment 11 Stephan Sokolow 2006-01-31 05:38:54 UTC
That's because the gtk flag specifies GTK support. the gtk2 flag means "use GTK2 if GTK support is enabled and the program supports both GTK1 and GTK2".
Comment 12 Xake 2006-01-31 12:42:24 UTC
(In reply to comment #11)
> That's because the gtk flag specifies GTK support. the gtk2 flag means "use
> GTK2 if GTK support is enabled and the program supports both GTK1 and GTK2".
> 

I think it is time for you to update you knowledge of the USE-flags.
A couple of months ago the default action for the gtk USE-flag became "Use gtk+2 if avaible, else use gtk" and there was ALOT of package-updating with this change...

Ceck out bug #106560 and http://thread.gmane.org/gmane.linux.gentoo.devel/31638 for more info about the "gtk2 use flag deprecation".
Comment 13 Patrick McLean gentoo-dev 2006-02-08 21:42:38 UTC
Hmm, gtk2 USE flag may be depricated, but the gtk2 patch is completely unsupported by the mplayer developers, so it would be preferrable not to have this patch in by default.

Maybe another local use flag would be more appropiate?
Comment 14 Patrick McLean gentoo-dev 2006-02-08 21:47:36 UTC
GTK2 is now the default in the package.mask'ed media-video/mplayer-1.0.20060102 
Comment 15 Ryan Hendrickson 2006-02-26 20:28:35 UTC
And now that mplayer-1.0.20060217 uses GTK2 only and has been marked stable, I daresay this bug should be closed?