Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 111364 - ebuild for wifiscanner 1.0.1 (version bump)
Summary: ebuild for wifiscanner 1.0.1 (version bump)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Mobile Herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-03 08:03 UTC by Poggi Jérôme
Modified: 2006-01-02 12:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for WifiScanner-1.0.1 (wifiscanner-1.0.1.ebuild,1.06 KB, text/plain)
2005-11-03 08:26 UTC, Poggi Jérôme
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Poggi Jérôme 2005-11-03 08:03:15 UTC
please find attached an ebuild for the wifiscanner 1.0.1 hosted on sourceforge.
This version correct the collision with Ethereal Bug #88331

Reproducible: Always
Steps to Reproduce:
Comment 1 Poggi Jérôme 2005-11-03 08:26:22 UTC
Created attachment 72025 [details]
ebuild for WifiScanner-1.0.1
Comment 2 Priit Laes (IRC: plaes) 2005-12-26 05:16:29 UTC
Looks good to me.
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2005-12-26 05:36:26 UTC
(In reply to comment #1)
> Created an attachment (id=72025) [edit]
> ebuild for WifiScanner-1.0.1
> 

A couple of comments to improve your ebuild writing skills:

DEPEND="${RDEPEND} sys-libs/zlib
zlib is part of system and as such not needed here
http://dev.gentoo.org/~plasmaroo/devmanual//general-concepts/dependencies/

This is also in the current ebuild because of which it is always best to be aware that also ebuilds in the tree can have QA problems.

src_install () {

It is customary to have the functions in the order they are executed so src_install comes after src_compile

	local config=""
	if ! use ethereal; then
		config="${config} --with-internal-wiretap --enable-wtap"
	else
		config="${config} --without-internal-wiretap --enable-wtap"
	fi

This is how I would do this:

	local config="--enable-wtap"
	if use ethereal; then
		config="${config} --without-internal-wiretap"
	else
		config="${config} --with-internal-wiretap"
	fi

This is not especially long so you can just put in on one line
	econf ${config} --enable-curses || die "econf failed"

Is there a reason that curses is not use flagged?

Thanks for the work so far.
Comment 4 Petteri Räty (RETIRED) gentoo-dev 2005-12-26 05:38:24 UTC
Hmm. sorry, there is an even better way to do this:

config="${config} --with-internal-wiretap --enable-wtap"

http://dev.gentoo.org/~plasmaroo/devmanual//ebuild-writing/functions/src_compile/configure/
Comment 5 Stefan Schweizer (RETIRED) gentoo-dev 2006-01-02 12:35:24 UTC
thanks, fixed