Bug 110975 – portage-utils-0.1.7 doesn't compile due to a buggy comment in libq/virtuals.c

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jose Luis Rivero (yoswink) (RETIRED) 2005-10-31 00:35:05 UTC]

While testing portage-utils-1.0.7 on alpha or x86, if I try to compile it i get
the follow error: 

>>> Unpacking portage-utils-0.1.7.tar.bz2 to
/var/tmp/portage/portage-utils-0.1.7/work
>>> Source unpacked.
cc -march=pentium4 -O2 -pipe main.c -o q
In file included from libq/libq.c:19,
                 from main.c:116:
libq/virtuals.c:18:18: missing terminating ' character
libq/virtuals.c:186: warning: `resolve_virtuals' defined but not used
distcc[12831] ERROR: compile main.c on localhost failed
make: *** [q] Error 1

!!! ERROR: app-portage/portage-utils-0.1.7 failed.
!!! Function src_compile, Line 556, Exitcode 2
!!! emake failed
!!! If you need support, post the topmost build error, NOT this status message.

Seems to be a little problem with a comment on libq/virtuals.c:18, the two lines
beggining with <jstubbs> need the open comment mark. 

I don't send a patch because it's a two char fix. Please ask if need more info
about this. 

Thanks.

[Comment 1 solar (RETIRED) 2005-10-31 05:03:27 UTC]

What gcc version does this happen with?

[Comment 2 Steven Coutts 2005-10-31 05:13:26 UTC]

Works fine on my system -:

gcc (GCC) 3.4.4 (Gentoo 3.4.4-r1, ssp-3.4.4-1.0, pie-8.7.8)

[Comment 3 solar (RETIRED) 2005-10-31 07:52:32 UTC]

This is fixed the ebuild and cvs trees btw. 
I still want to know what gcc versions. Or if it only happens with distcc.

[Comment 4 Robert Paskowitz (RETIRED) 2005-10-31 08:27:07 UTC]

I hit this with i686-pc-linux-gnu-3.3.6, non-vanilla (USE=hardened)
distcc was not in use

[Comment 5 solar (RETIRED) 2005-10-31 08:54:46 UTC]

Thanks. I got it to happen with 3.3.6 also. 3.4.x and 4.x handle this code just 
fine. 

#if 0
/var/db/pkg/*/*/blah */
#endif

None the less can you guys --sync up and confirm it's fixed before 
closing this bug.

[Comment 6 Jose Luis Rivero (yoswink) (RETIRED) 2005-10-31 09:16:05 UTC]

Ned, sorry about didn't send the gcc version before.

gcc (GCC) 3.3.5-20050130 (Gentoo Linux 3.3.5.20050130-r1, ssp-3.3.5.20050130-1,
pie-8.7.7.1)

And with respect to distcc, failed also without it.

Works like a charm now. Thanks.

[Comment 7 solar (RETIRED) 2005-10-31 09:27:30 UTC]

Closing as FIXED