Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 109639 - --sysconfdir statement in xorg-server-0.99_p20051013-r1.ebuild leads to wrong install path
Summary: --sysconfdir statement in xorg-server-0.99_p20051013-r1.ebuild leads to wrong...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Highest minor (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 110196
  Show dependency tree
 
Reported: 2005-10-17 15:17 UTC by Walter Meinl
Modified: 2005-10-25 09:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Meinl 2005-10-17 15:17:13 UTC
In the xorg-server-0.99.1_p20051013-r1.ebuild you find in the CONFIGURE_OPTIONS
--sysconfdir=/etc/X11. The only file that is affected is XOrgCfg that should go
in /etc/X11/app-defaults. However with the sysconfdir settings of the ebuild it
will be installed into /etc/X11/X11/app-defaults (and wont be found by xorgcfg)
as in the xorgcfg/Makefile it is defined to go to $(sysconfdir)/X11.
equery f xorg-server
x11-base/xorg-server-0.99.1_p20051013-r1
/etc
/etc/X11
/etc/X11/X11
/etc/X11/X11/app-defaults
/etc/X11/X11/app-defaults/XOrgCfg
/usr
/usr/bin
/usr/bin/X -> Xorg
/usr/bin/Xdmx
....
Removing the --sysconfdir line from the ebuild let it install properly in
/etc/X11/app-defaults (as sysconfdir in configure is set to /etc). I know its at
the moment not so important as modular xorgcfg seems not yet really ready. Just
a reminder to remove the line in case of other/further changes to the ebuild. Thanks
Comment 1 Joshua Baergen (RETIRED) gentoo-dev 2005-10-18 10:41:06 UTC
Donnie, is there a reason to keep this line as it is?
Comment 2 Donnie Berkholz (RETIRED) gentoo-dev 2005-10-18 12:21:08 UTC
Not if things work fine without.
Comment 3 Joshua Baergen (RETIRED) gentoo-dev 2005-10-23 11:39:50 UTC
app-defaults is now installed to /usr/lib/X11 regardless of sysconfdir, due to
an upstream decision if I remember correctly...

Do we want to patch the source so that it installs where the rest of the
app-defaults are?
Comment 4 Donnie Berkholz (RETIRED) gentoo-dev 2005-10-23 20:32:10 UTC
I see in the comments of the ebuild:

# sysconfdir is used for the xorg.conf location

So if you don't pass sysconfdir, then your xorg.conf won't get found.
Comment 5 Joshua Baergen (RETIRED) gentoo-dev 2005-10-24 16:14:00 UTC
Ehhe, missed that.

Anyways, #3?
Comment 6 Donnie Berkholz (RETIRED) gentoo-dev 2005-10-24 20:29:50 UTC
Well as far as app-defaults installing right, it's fixed in upstream CVS and in
the current xorg-server version in portage so I don't see why we should patch an
older version.
Comment 7 Joshua Baergen (RETIRED) gentoo-dev 2005-10-24 22:07:53 UTC
The reason I bring it up is that /usr/lib/X11 is where the current xorg-server
version installs app-defaults, but many other apps install to /etc/X11/.
Comment 8 Donnie Berkholz (RETIRED) gentoo-dev 2005-10-24 22:17:20 UTC
Then the other packages will have to get fixed.
Comment 9 Walter Meinl 2005-10-25 02:34:01 UTC
Indeed, due to the last minute changes to the location of the app-defaults dir
this bug is probably not valid anymore since most people won't install "older"
xorg-server versions. Yesterday I built xorg-server three times, using the
original ebuild with sysconfdir=/etc/X11, one with the setting sysconfdir=/etc
and  finally w/o sysconfdir setting at all. I did an ebuild
xorg-server-0.99.2-r1 install. There were apperantly no differences. XOrgCfg,
the file in question was found in all three variations in
...../image/usr/lib/X11/app-defaults. None of these builds gave me a /etc
directory within the image and no xorg.conf file was created with any of those
ebuilds. So probably this bug can be closed with solution upstream?
Comment 10 Walter Meinl 2005-10-25 02:43:37 UTC
(In reply to comment #7)
> The reason I bring it up is that /usr/lib/X11 is where the current xorg-server
> version installs app-defaults, but many other apps install to /etc/X11/.

I found several ebuilds on my system installing to /etc/X11. Those related to
modular X are xdm init and xfs (all newest versions). I could give you a
complete list, but maybe you want to open a new bug for this? Most notably is
this regard is groff, as it belongs to system and is probably installed before
any x11-app. The groff ebuild does not install any file in app-defaults, but
creates /usr/lib/X11/app-defaults as a symlink to /etc/X11/app-defaults.
Therefore, in principal every gentoo user should have this symlink.
Comment 11 Donnie Berkholz (RETIRED) gentoo-dev 2005-10-25 09:10:22 UTC
Yeah, a new bug would be good.