Bug 109549 – gspoof fails to call pkg-config --cflags cairo, so it gets the wrong path

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ryan O'Hara 2005-10-17 03:00:58 UTC]

cairo #includes are missing the cairo/ directory.

for example it's headers use #include <whatever.h> instead of #include
<cairo/whatever.h>

Upstream may need to fix this and put headers in an include directory instead of
src/.

[Comment 1 John N. Laliberte (RETIRED) 2005-10-17 05:41:31 UTC]

is this causing a problem?

please cite a filename plus linenumber as an example.

[Comment 2 Ryan O'Hara 2005-10-17 06:24:03 UTC]

Yes it causes a problem in configure scripts for example working around paths.

cairo/cairo.h line 41 is an example It should be #include
<cairo/cairo-features.h>. Gentoo puts cairo headers in /usr/include/cairo, but
cairo seems think they are in /usr/include only.

[Comment 3 G HUNT 2005-11-11 17:15:00 UTC]

here's an example of filename and linenumber. 
  
emerge gspoof  
Calculating dependencies ...done!  
>>> emerge (1 of 1) net-analyzer/gspoof-3.2 to /  
>>> md5 files   ;-) gspoof-3.2.ebuild  
>>> md5 files   ;-) files/digest-gspoof-3.2  
>>> md5 src_uri ;-) gspoof-3.2.tar.gz  
>>> Unpacking source...  
>>> Unpacking gspoof-3.2.tar.gz to /mnt/OS/portage/gspoof-3.2/work  
>>> Source unpacked.  
gcc -Wall -O2  -I/usr/include -I/usr/include/gtk-2.0  
-I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0  
-I/usr/X11R6/include -I/usr/include/freetype2 -I/usr/include/glib-2.0  
-I/usr/lib/glib-2.0/include   -c main.c -o main.o  
In file included from /usr/include/gtk-2.0/gdk/gdkcairo.h:23,  
                 from /usr/include/gtk-2.0/gdk/gdk.h:30,  
                 from /usr/include/gtk-2.0/gtk/gtk.h:31,  
                 from gtk.h:13,  
                 from main.c:20:  
/usr/include/gtk-2.0/gdk/gdkcolor.h:30:19: cairo.h: No such file or directory  
In file included from /usr/include/gtk-2.0/gdk/gdkcairo.h:25,  
                 from /usr/include/gtk-2.0/gdk/gdk.h:30,  
                 from /usr/include/gtk-2.0/gtk/gtk.h:31,  
                 from gtk.h:13,  
                 from main.c:20:  
  (In reply to comment #0)
> cairo #includes are missing the cairo/ directory.
> 
> for example it's headers use #include <whatever.h> instead of #include
> <cairo/whatever.h>
> 
> Upstream may need to fix this and put headers in an include directory instead of
> src/.

[Comment 4 G HUNT 2005-11-11 17:31:32 UTC]

hmm... actually gspoof is the problem here in this case.

the ebuild fails to run configure.. so disregard my previous comments...

[Comment 5 Doug Goldstein (RETIRED) 2005-12-20 21:39:47 UTC]

if gspoof properly ran pkg-config then it would get the proper info. Not a Cairo bug. 

re-assigning to spock since he maintains this package.

[Comment 6 Michal Januszewski (RETIRED) 2005-12-24 16:35:57 UTC]

Fixed in CVS, thanks.