Bug 108953 – pmount compile error

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Tim Cleaver 2005-10-11 19:51:28 UTC]

pumount.c: 155 LC_ALL not defined due to not including <locale.h> in the file

Reproducible: Always
Steps to Reproduce:
1. add sys-apps/pmount ~ppc to package.keywords
2. emerge sys-apps/pmount (on Linux powerbook 2.6.13-gentoo-r3 #1 Sun Oct 9
11:31:33 EST 2005 ppc 7447/7457, altivec supported PowerBook5,2 GNU/Linux
)
3.

Actual Results:  
compile error

Expected Results:  
clean compile

All that was required was to include <locale.h> in pumount.c. Sorry if this is
the wrong place to post this bug. I didn't have much luck figuring out where
else it should be posted. I made the change locally and fixed it no worries so I
thought I would post it here so that those in the know can get the fix sent
upstream or wherever it has to go.

[Comment 1 Alec Warner (RETIRED) 2005-10-11 21:31:33 UTC]

Please include the version of pmount you were having issues with.

[Comment 2 Tim Cleaver 2005-10-12 19:26:21 UTC]

Version of pmount is 0.9.3-r3. 

[Comment 3 Doug Goldstein (RETIRED) 2005-10-12 21:04:13 UTC]

I'm most defintely going to need emerge info on this bug.

[Comment 4 Tim Cleaver 2005-10-16 16:56:21 UTC]

Here is emerge --info

Portage 2.0.51.22-r3 (default-linux/ppc/2005.1/ppc/G4, gcc-3.4.4,
glibc-2.3.4.20041102-r1, 2.6.13-gentoo-r3 ppc)
=================================================================
System uname: 2.6.13-gentoo-r3 ppc 7447/7457, altivec supported
Gentoo Base System version 1.6.13
ccache version 2.3 [enabled]
dev-lang/python:     2.3.5, 2.4.2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.15.90.0.3-r5
sys-devel/libtool:   1.5.18-r1
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="ppc"
AUTOCLEAN="yes"
CBUILD="powerpc-unknown-linux-gnu"
CFLAGS=" -I/home/tim/include -I/usr/include -I/usr/local/include
-I/usr/X11R6/include"
CHOST="powerpc-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config /var/qmail/c
ontrol"
CONFIG_PROTECT_MASK="/etc/gconf /etc/splash /etc/terminfo /etc/texmf/web2c
/etc/env.d"
CXXFLAGS="-O2 -mtune=G4 -mcpu=G4 -mabi=altivec -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks sandbox sfperms strict"
GENTOO_MIRRORS="ftp://ftp.planetmirror.com/pub/gentoo
ftp://mirror.pacific.net.au/linux/Gentoo http://mirror.isp.net.au/pub/gentoo
ftp://mirror.isp .net.au/pub/gentoo"
LDFLAGS=" -L/home/tim/lib -L/usr/lib -L/usr/local/lib -L/usr/X11R6/lib"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.au.gentoo.org/gentoo-portage"
USE="ppc X a52 aac accessibility aim alsa altivec apm audiofile bash-completion
berkdb bitmap-fonts bluetooth bzip2 cdparanoia cdr crypt cups curl dio directfb
dri dvd dvdr eds emboss encode esd exif fam fbcon ffmpeg fftw flac flash fortran
ftp gcj gif glut gnome gnutls gphoto2 gpm gstreamer g tk gtk2 hal howl iconv icq
ieee1394 imagemagick imlib ipv6 jabber jack java javascript jikes jpeg junit
kerberos lcms ldap libwww mad mime ming mma p mng motif mozilla mp3 mpeg msn nas
ncurses nls ntpl offensive ogg oggvorbis openal opengl oscar oss pam pcmcia
pcntl pdflib perl png portaudio po six ppds profile python quicktime readline
recode samba sdl slang slp sndfile snmp sockets speex spell sqlite ssl svg
symlink tcpd tetex theora thr eads tiff truetype truetype-fonts type1-fonts
unicode usb vorbis wifi xface xine xinerama xml2 xpm xprint xv xvid yahoo zlib
userland_GNU kernel_li nux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LINGUAS, MAKEOPTS, PORTDIR_OVERLAY


Hope this helps

[Comment 5 Doug Goldstein (RETIRED) 2005-10-16 18:45:22 UTC]

Um. It's your CFLAGS. Look at them. They're breaking this. Don't override the
include paths. You're also not including the necessary ones for ppc. CXXFLAGS
and CFLAGS are way out of wack. CXXFLAGS should be in CFLAGS.

[Comment 6 Tim Cleaver 2005-10-17 01:00:51 UTC]

I didn't realise that CFLAGS were retained across an su and an emerge. They
aren't set to be that in my make.conf. As a normal user I have the CFLAGS set to
CFLAGS="$CFLAGS (additional includes)" in my .bashrc which i then typically su
from to emerge packages. (In make.conf they are set to what CXXFLAGS is). I set
CFLAGS because I build enlightenment from cvs and want to keep it separate so
that when it becomes stable in portage (if it ever gets released) i can install
it and get rid of the cvs version easily. I will move those definitions from my
.bashrc to the build scripts for enlightenment. Sorry for any inconvenience.

[Comment 7 Tim Cleaver 2005-10-17 01:27:16 UTC]

I tested moving the CFLAGS into the enlightenment build scripts and it worked.
Sorry again for this. Thanks for your help.