Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 108911 - Version bump: dev-utils/weka-3.4.6
Summary: Version bump: dev-utils/weka-3.4.6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Java team
URL: http://www.cs.waikato.ac.nz/~ml/weka/
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2005-10-11 11:52 UTC by Stefan de Konink
Modified: 2005-12-05 23:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
the ebuild (weka-3.4.6.ebuild,1.19 KB, text/plain)
2005-11-10 01:53 UTC, lzap
Details
general ant script (to files/) (build.xml,2.43 KB, text/plain)
2005-11-10 01:53 UTC, lzap
Details
small die-fix (weka-3.4.6.ebuild,1.20 KB, text/plain)
2005-11-10 02:01 UTC, lzap
Details
all comments fixed (weka-3.4.6.ebuild,1.21 KB, text/plain)
2005-11-10 02:12 UTC, lzap
Details
and next fixes (weka-3.4.6.ebuild,1.35 KB, text/plain)
2005-11-10 02:23 UTC, lzap
Details
fix for generating javadocs (weka-3.4.6.ebuild,1.36 KB, text/plain)
2005-11-11 11:38 UTC, lzap
Details
Fixed ebuild. (weka-3.4.6.ebuild,1.72 KB, text/plain)
2005-11-30 14:38 UTC, lzap
Details
Fixes, final version (weka-3.4.6.ebuild,1.68 KB, text/plain)
2005-12-05 07:14 UTC, lzap
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan de Konink 2005-10-11 11:52:10 UTC
Current stable version is at 3.4.6, unstable version is at 3.5.1.

Reproducible: Always
Steps to Reproduce:
Comment 1 Stefan de Konink 2005-10-11 16:07:31 UTC
Additional: it would be cool if the data directory/examples were world readable.
Comment 2 lzap 2005-11-08 15:56:52 UTC
Working on that
Comment 3 lzap 2005-11-10 01:51:41 UTC
I am done, this is complete rewrite, it fetches the source package directly, it
properly compiles the source with ant (I have provided the general ant script
created by java-devs), it understand "doc" USE properly and it fixes the data
directory
Comment 4 lzap 2005-11-10 01:53:08 UTC
Created attachment 72565 [details]
the ebuild

please test && commit
Comment 5 lzap 2005-11-10 01:53:40 UTC
Created attachment 72566 [details]
general ant script (to files/)
Comment 6 lzap 2005-11-10 02:01:58 UTC
Created attachment 72567 [details]
small die-fix

fixes one unimportant issue, thnx to axxo
Comment 7 Petteri Räty (RETIRED) gentoo-dev 2005-11-10 02:04:30 UTC
(In reply to comment #4)
> Created an attachment (id=72565) [edit]
> the ebuild
> 
> please test && commit

use doc && java-pkg_dohtml -r doc/* && dodoc *pdf

Now if dohtml for some reason fails it will just silently not install the pdf files.

VERSION_WEKA=$(replace_all_version_separators '-')
Usually ebuilds use MY_PV for example.

Thanks for the work so far.
Comment 8 lzap 2005-11-10 02:12:58 UTC
Created attachment 72568 [details]
all comments fixed
Comment 9 lzap 2005-11-10 02:23:47 UTC
Created attachment 72569 [details]
and next fixes

from #gentoo-java
Comment 10 lzap 2005-11-11 11:38:14 UTC
Created attachment 72688 [details]
fix for generating javadocs

and I masked ALL architectures as recommended on ICQ
Comment 11 Stefan de Konink 2005-11-15 05:31:28 UTC
skinkie@eshara ~ $ weka 
Warning, unable to load properties file from system resource (Utils.java)
Uncaught error fetching image:
java.lang.NullPointerException
        at sun.awt.image.URLImageSource.getConnection(URLImageSource.java:99)
        at sun.awt.image.URLImageSource.getDecoder(URLImageSource.java:108)
        at
sun.awt.image.InputStreamImageSource.doFetch(InputStreamImageSource.java:248)
        at sun.awt.image.ImageFetcher.fetchloop(ImageFetcher.java:172)
        at sun.awt.image.ImageFetcher.run(ImageFetcher.java:136)

In combination with weka-3.4.6. Doesn't work as root too.
Comment 12 lzap 2005-11-30 14:38:08 UTC
Created attachment 73857 [details]
Fixed ebuild.

Theres no need of build.xml file now!

Tested, works well.

If the package wont start under root, please check that java is avaiable under
root (executing `java -version`).
Comment 13 Petteri Räty (RETIRED) gentoo-dev 2005-11-30 14:48:48 UTC
(In reply to comment #12)

> 
> If the package wont start under root, please check that java is avaiable under
> root (executing `java -version`).

You can use $(java-config --java) to not have to rely on $PATH to locate java.
Comment 14 lzap 2005-12-05 01:07:42 UTC
(In reply to comment #13)
> You can use $(java-config --java) to not have to rely on $PATH to locate java.

Stefan can you test it? It works for me.

Also here: http://www.ebuildexchange.org/eshow.php?id=10087
Comment 15 Josh Nichols (RETIRED) gentoo-dev 2005-12-05 06:24:08 UTC
The ebuild is starting to look pretty good. These comments are nitpicks and/or
stylistic comments

* weka is in the SRC_URI. You should use ${PN} instead.

* If you're going to use ${PN}-${MY_PV} more than once, you should define this
MY_P, and then use it in the SRC_URI and S.

* If you're distfile is a zip, you need to DEPEND on app-arch/unzip

* Instead of using jar to extract, you might want instead to do:
unzip -qq weka-src.jar -d src
  The q's make the output quit, and -d specifies where the extracted files
should go. It'll make src_unpack a little cleaner.

* As you don't need a build.xml anymore, you probably don't need to copy it in
${S} anymore

* I would put jar up the classes/resources during src_compile, since it is part
of the build process. It should also have || die "Failed to create jar"

* If you only have one thing to do for an if statement, you can go like:
use source && java-pkg_dosrc src/*
Comment 16 lzap 2005-12-05 07:14:43 UTC
Created attachment 74098 [details]
Fixes, final version

Everything fixed and cleaned.
Comment 17 Stefan de Konink 2005-12-05 13:51:14 UTC
This morning I compiled the weka without problems.
Comment 18 Josh Nichols (RETIRED) gentoo-dev 2005-12-05 17:14:37 UTC
I just tried building on amd64 with blackdown 1.4, and seem to be getting
OutOfMemoryErrors. No idea why...
Comment 19 Josh Nichols (RETIRED) gentoo-dev 2005-12-05 18:19:28 UTC
Added to CVS. Thanks for the contribution!

Just a note, I made a few changes before committing:
* Added virtual/x11 as an RDEPEND, since it is a GUI application.
* Dropped ~sparc ~ia64 keywords because I wasn't able to test those archs, and
the previous version lacked those keywords. If they do work on those platforms,
please file a separate bug.
* Removed mkdir src, since the unzip will make it if it doesn't exist.
* Made the wrapper script do an 'exec', so that the shell will get the right
return value when weka exits.
Comment 20 lzap 2005-12-05 23:38:33 UTC
Thanks Josh!

ps - OutOfMemory error - you need to raise the VM heap stack limit up