Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 108637 - x264-svn needs one more USE flag and use_enable
Summary: x264-svn needs one more USE flag and use_enable
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Marc Hildebrand (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-09 11:18 UTC by James Cloos
Modified: 2006-03-05 09:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for cvs drop of gpac (gpac-0.4.1.ebuild,2.31 KB, text/plain)
2005-10-19 22:16 UTC, James Cloos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description James Cloos 2005-10-09 11:18:34 UTC
I see that x264-svn supports an --enable-mp4-output configure flag.
The ebuild should support that via:

  $(use_enable gpac mp4-output)

and the addition of gpac to IUSE.

Gpac is in portage as media-video/gpac; the only version is keyworded '~ppc
~x86", but that is OK since x264-svn is keyworded '-* ~x86'.
Comment 1 James Cloos 2005-10-09 11:21:02 UTC
BTW, I forget to mention, mp4 output is of course the primary distribution
format for H.264 video, so allowing x264 to output to that format is important.
 Otherwise it can only output to a raw bitstream or to a matroska file.
Comment 2 Marc Hildebrand (RETIRED) gentoo-dev 2005-10-10 22:42:26 UTC
Yes, I know.
Have you managed to compile x264 against gpac?
Comment 3 aizvorski 2005-10-11 21:39:11 UTC
Marc: x264 since svn revision 299 (2005-09-24) requires gpac >= 0.4.0.  Earlier
versions require gpac = 0.2.4.  Hope that helps.  I agree that adding gpac would
be useful, but we need to get a newer version into portage first.
Comment 4 James Cloos 2005-10-11 23:45:44 UTC
I was working on a reply to comment 2 when comment 3 came in.

(Downloading gpac 0.4.0 and gpac_extra_libs 0.4.0 takes quite a while over a straw.)

I looks like upgrading gpac to 0.4.0 and adding a make install-lib to its ebuild
will be enough to make use of it in x264.

I'll post another reply once I confirm, along with a proposed ebuild for gpac
0.4.0.  
Comment 5 James Cloos 2005-10-12 12:59:19 UTC
I just confirmed that x264-svn needs gpac-cvs rather than just gpac-0.4.0.

At the very least the function gf_isom_open() from gpac had added a third
argument since the 0.4.0 release and x264-svn expects that.

Comment 6 James Cloos 2005-10-12 21:15:02 UTC
I made a tar of gpac's cvs tree and installed it via a modified ebuild.

That done, x264-svn, configured with --enable-mp4-output, compiled and installed.

So, to add $(use_enable gpac mp4-output) to x264-svn will require either an
'interm release' of gpac or creation of a gpac-cvs ebuild.
Comment 7 Marc Hildebrand (RETIRED) gentoo-dev 2005-10-16 03:25:35 UTC
Well, I tried the same several times now and I always get the same error when 
compiling x264 afterwards: 
 
------------------------------------------------- 
/usr/lib/gcc/i686-pc-linux-gnu/3.4.4/../../../../i686-pc-linux-gnu/bin/ld: 
cannot find -lgpac_static 
collect2: ld returned 1 exit status 
make: *** [x264] Error 1 
------------------------------------------------- 
 
Both gpac and x264 are fresh checkouts. 
 
Any ideas? 
Cheers, 
Marc. 
 
Comment 8 Chris Motch 2005-10-18 11:46:13 UTC
The reason why this error :
------------------------------------------------- 
/usr/lib/gcc/i686-pc-linux-gnu/3.4.4/../../../../i686-pc-linux-gnu/bin/ld: 
cannot find -lgpac_static 
collect2: ld returned 1 exit status 
make: *** [x264] Error 1 
------------------------------------------------- 
is that the library generated by gpac is actually lgpac.  If you modify the
configure to link against this library is works, I've been spending the last few
hours trying to get the x264 encoder working with VLC, this was one of my road
blocks.
Comment 9 James Cloos 2005-10-19 22:16:32 UTC
Created attachment 71056 [details]
ebuild for cvs drop of gpac

With this ebuild and a cvs checkout of gpac I was able to get x264-svn to
compile with --use-mp4-output.
Comment 10 Marc Hildebrand (RETIRED) gentoo-dev 2006-03-05 09:27:26 UTC
I added a gpac-snapshot-ebuild and an ebuild that adds mp4-output to x264.
Please check.
Cheers,
Marc