Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 108471 - Soundtracker 0.6.7 can be marked ~alpha.
Summary: Soundtracker 0.6.7 can be marked ~alpha.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: Alpha Linux
: High enhancement (vote)
Assignee: Alpha Porters
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-08 03:26 UTC by Laurens Vets
Modified: 2006-04-02 11:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
soundtracker-0.6.7-r1.ebuild (soundtracker-0.6.7-r1.ebuild,1.58 KB, text/plain)
2006-01-12 12:23 UTC, Thomas Cort (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Laurens Vets 2005-10-08 03:26:06 UTC
Hi guys,

I've emerged Soundtracker 0.6.7 on alpha and it compiles and works.  I did not
run into bug 91619 or anything similar.

Best regards,
Laurens Vets

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Thomas Cort (RETIRED) gentoo-dev 2006-01-12 12:23:39 UTC
Created attachment 76935 [details]
soundtracker-0.6.7-r1.ebuild

I verified that the patch is correct. It removes a line in midi_init() in app/midi-09x.c that free()'s a variable called "port_sub". Removing the line doesn't cause a memory leak as the variable is allocated on the stack by the line snd_seq_port_subscribe_alloca(&port_sub). free()'ing that memory caused the crash. The crash doesn't happen all of the time because the line that causes the error is in a block of code that only gets executed if snd_seq_subscribe_port( midi_handle, port_sub) returns an error.

This ebuild applies the patch in attachement #67640. Download the patch to soundtracker-0.6.7-invalid-free-fix.patch and put it in the files directory.
Comment 2 Thomas Cort (RETIRED) gentoo-dev 2006-01-12 12:27:07 UTC
Oops, that Attachment #76935 [details] was supposed to go on Bug #91618. It references the patch in Attachment #67640 [details, diff]. BTW, I tested the patch and soundtracker-0.6.7 and it builds and works on alpha.
Comment 3 Thomas Cort (RETIRED) gentoo-dev 2006-04-02 11:09:48 UTC
Added ~alpha. Thanks for testing this Laurens.