Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 108464 - Bugfix-patches for ifplugd start/stop script
Summary: Bugfix-patches for ifplugd start/stop script
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Roy Marples (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-08 02:24 UTC by Christian Roessner
Modified: 2005-10-10 00:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ifplugd.diff (ifplugd.diff,652 bytes, text/plain)
2005-10-08 02:25 UTC, Christian Roessner
Details
correct fix for ifplugd (ifplugd.patch,1.15 KB, patch)
2005-10-09 08:04 UTC, Roy Marples (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Roessner 2005-10-08 02:24:44 UTC
Hi,

I have fixed some bugs in /etc/init.d/ifplugd (=sys-apps/ifplugd-0.28-r2)

Have a nice day

Christian


Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Christian Roessner 2005-10-08 02:25:13 UTC
Created attachment 70133 [details]
ifplugd.diff
Comment 2 Roy Marples (RETIRED) gentoo-dev 2005-10-09 06:30:05 UTC
The is_set function isn't broken, your patch appears to break it.....

SIGQUIT is signal 3 - SIGQUIT is easier to read, why the need to change to 3?

So why is this needed? Until a good argument can be given, I'll mark it as WONTFIX
Comment 3 Christian Roessner 2005-10-09 07:37:04 UTC
First thing: is_set does not work here on amd64! If using == yes, then the
options --no-auto and --no-beep are not set (-ab).

Second: On both my machines (notebook and amd64) the init script does not
stop/restart, because portage tells me it needs a signal name or a signal
number. You used SIGQUIT and therefor it seems, portage is broken here. But
using a real number fixes this. So this is not really a bug in ifplugd but maybe
in start-stop-daemon (is this portage or baselayout??)

So if you do not change both things, the ifplugd stuff is broken on nearly all
~arch systems I (would) bet

I put some einfo in the is_set function to see the result

einfo "$1 $2 $3" and I got numbers 0/1. Not boolean words. So I changed it to -eq.

Hope you will test this. ;-)

Thanks anyway

Christian
Comment 4 Roy Marples (RETIRED) gentoo-dev 2005-10-09 08:04:44 UTC
Created attachment 70223 [details, diff]
correct fix for ifplugd

OK, the is_set function does work - the error is assigning to an invalid iargs
variable.

The SIGQUIT option works for baselayout-1.12.0_pre* as we intercept
start-stop-daemon calls, but you're correct as 3 is needed for baselayout<1.12

Test this patch and see if it fixes your issues.
Comment 5 Christian Roessner 2005-10-09 13:34:41 UTC
It works, although I don
Comment 6 Christian Roessner 2005-10-09 13:34:41 UTC
It works, although I don´t understand the changes. But the patch is okay.

Thanks

Christian
Comment 7 Roy Marples (RETIRED) gentoo-dev 2005-10-10 00:39:43 UTC
Fixed in ifplugd-0.28-r3