Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 108252 - /etc/init.d/modules re-directs stderr to /dev/null - no visible error messages in case of failures
Summary: /etc/init.d/modules re-directs stderr to /dev/null - no visible error message...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-06 01:50 UTC by Lyall Pearce
Modified: 2005-10-06 18:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lyall Pearce 2005-10-06 01:50:30 UTC
/etc/init.d/modules is supposed to rebuild /etc/modules.conf (amongst others)
using /sbin/modules-update

If this file is corrupted in any way (say by using XFS filesystem and having a
power fail), then it will not re-build unless /sbin/modules-update given the
'force' option.

However, /etc/init.d/modules re-directs /sbin/modules-update to /dev/null,
hiding the error messages generated (no logs are generated as to why the modules
rebuild fails) so the admin is left wondering what went wrong.


Reproducible: Always
Steps to Reproduce:
1. edit /etc/modules.conf to be garbage
2. execute /etc/init.d/modules
3. rebuild fails but no logs or messages indicating why

Actual Results:  
have to run '/sbin/module-update force' by hand to fix all the files.
Subsequent re-boots work fine.

Expected Results:  
Errors generated by /sbin/module-update to be visible so that the root cause can
be quickly determined, possibly even running /sbin/module-update force.
I suggest the force bit as failure to create these files results in an unusable
system (mine, the network failed to start)


fix is as follows :-

$ diff --unified modules modules~
--- modules     2005-10-05 06:21:23.168731104 +0930
+++ modules~    2005-08-25 20:03:32.000000000 +0930
@@ -88,7 +88,7 @@
        if [ -z "${CDBOOT}" ] && touch /etc/modules.conf 2> /dev/null
        then
                ebegin "Calculating module dependencies"
-               /sbin/modules-update
+               /sbin/modules-update &>/dev/null
                eend $? "Failed to calculate module dependencies"
        fi 


$ emerge --info
Portage 2.0.51.22-r2 (default-linux/x86/2005.1, gcc-3.3.6, glibc-2.3.5-r1,
2.6.12-gentoo-r9 i686)
=================================================================
System uname: 2.6.12-gentoo-r9 i686 Intel(R) Pentium(R) 4 CPU 2.60GHz
Gentoo Base System version 1.6.13
dev-lang/python:     2.3.5-r2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.15.92.0.2-r10
sys-devel/libtool:   1.5.18-r1
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -mcpu=i686 -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.3/env
/usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3.4/env
/usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -mcpu=i686 -fomit-frame-pointer -pipe"
DISTDIR="/portage/Repository/distfiles"
FEATURES="autoconfig distlocks nostrip sandbox sfperms strict userpriv usersandbox"
GENTOO_MIRRORS="ftp://mirror.internode.on.net/pub/gentoo
ftp://mirror.pacific.net.au/linux/Gentoo http://mymirror.asiaosc.org/gentoo/
http://www.zentek-international.com/mirrors/gentoo/
http://open-systems.ufl.edu/mirrors/gentoo
http://www.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/portage/tmp"
PORTDIR="/portage/Repository"
SYNC="rsync://mirror.internode.on.net/gentoo-portage"
USE="x86 X alsa apache2 apm arts avi berkdb bitmap-fonts cdr crypt cups curl dvd
eds emboss encode esd fam foomaticdb fortran gd gdbm gif gnome gpm gstreamer gtk
gtk2 imagemagick imlib ipv6 java jpeg junit kde libg++ libwww mad mikmod motif
mp3 mpeg mysql ncurses nls ogg oggvorbis opengl oss pam pdflib perl png python
qt quicktime readline samba sdl spell sqlite ssl svga tcltk tcpd tiff truetype
truetype-fonts type1-fonts vorbis xml2 xmms xv zlib userland_GNU kernel_linux
elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTDIR_OVERLAY

""lyalls-pc:~
Comment 1 SpanKY gentoo-dev 2005-10-06 18:46:29 UTC
this has already been fixed in every version of baselayout but 1.11.13 ;)

fixed in that version in svn