Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 107917 - mozilla-firefox-1.0.7-r3 generates invalid compiler flags
Summary: mozilla-firefox-1.0.7-r3 generates invalid compiler flags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-02 11:23 UTC by Graham Murray
Modified: 2005-10-02 12:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Murray 2005-10-02 11:23:07 UTC
The patch to remove SSP from the CFLAGS seems to have generated invalid flags

checking whether the C compiler (i686-pc-linux-gnu-gcc  -march=nocona -pipe / -W
no-return-type -w ) works... no

I am sure that the '/' in the reported compiler command is invalid


Reproducible: Always
Steps to Reproduce:
1. emerge mozilla-firefox





emerge --info
Portage 2.0.53_rc3 (default-linux/x86/2005.1, gcc-3.4.4, glibc-2.3.5-r1,
2.6.13-gentoo-r2 i686)
=================================================================
System uname: 2.6.13-gentoo-r2 i686 Intel(R) Pentium(R) 4 CPU 3.20GHz
Gentoo Base System version 1.12.0_pre8
dev-lang/python:     2.3.5, 2.4.2
sys-apps/sandbox:    1.2.13
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1
sys-devel/libtool:   1.5.20
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=nocona -pipe -fstack-protector -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env
/usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config /var/bind
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/texmf/web2c /etc/env.d"
CXXFLAGS="-O2 -march=nocona -pipe -fstack-protector -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://ftp.du.se/pub/os/gentoo http://ftp.romnet.org/gentoo/
http://mirror.uni-c.dk/pub/gentoo/
http://mirrors.sec.informatik.tu-darmstadt.de/gentoo/
http://distro.ibiblio.org/pub/linux/distributions/gentoo/"
LANG="en_GB.UTF-8"
LC_ALL="en_GB.UTF-8"
LINGUAS="en_GB"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.us.gentoo.org/gentoo-portage"
USE="x86 X a52 aac aalib acl acpi aim alsa apache2 apm arts audiofile avi
bash-completion berkdb bitmap-fonts bonobo browserplugin bzip2 bzlib caps
cdparanoia cdr cjk crypt cups curl doc dts dvd dvdr eds emacs emboss encode esd
ethereal examples exif expat fam fbcon ffmpeg flac foomaticdb fortran gcj gd
gdbm gif glut gmp gnome gnutls gphoto2 gpm gstreamer gtk gtk2 gtkhtml guile
iconv icq ieee1394 imagemagick imlib ipv6 jabber jack java javascript jce jpeg
junit kde lcms leim libg++ libwww lm_sensors logrotate mad mbox mikmod milter
mime mmap mmx mng motif mozilla mp3 mpeg mpi msn ncurses nls nptl offensive ogg
oggvorbis opengl oscar oss pam pcntl pcre pdflib perl png postgres profile
python qt quicktime readline recode sdl sharedmem slang sndfile snmp sockets sox
speex spell sse ssl svg sysvipc tcltk tcpd tetex theora threads tiff truetype
truetype-fonts type1-fonts unicode usb v4l vhosts vorbis win32codecs wmf xface
xine xml xml2 xmms xv xvid yahoo zlib linguas_en_GB userland_GNU kernel_linux
elibc_glibc"
Unset:  ASFLAGS, CTARGET, LDFLAGS
Comment 1 Martin Schlemmer (RETIRED) gentoo-dev 2005-10-02 12:28:49 UTC
Whoops, typo my side.  Should be fixed in a while.

-----
Index: mozilla-firefox-1.0.7-r3.ebuild
===================================================================
RCS file:
/var/cvsroot/gentoo-x86/www-client/mozilla-firefox/mozilla-firefox-1.0.7-r3.ebuild,v
retrieving revision 1.1
diff -u -r1.1 mozilla-firefox-1.0.7-r3.ebuild
--- mozilla-firefox-1.0.7-r3.ebuild     2 Oct 2005 15:04:48 -0000       1.1
+++ mozilla-firefox-1.0.7-r3.ebuild     2 Oct 2005 19:28:08 -0000
@@ -112,10 +112,10 @@
        # hardened GCC uses -fstack-protector-all by default, which breaks us
        has_hardened && append-flags -fno-stack-protector-all
        # remove -fstack-protector because now it borks firefox
-       CFLAGS=${CFLAGS/-fstack-protector-all//}
-       CFLAGS=${CFLAGS/-fstack-protector//}
-       CXXFLAGS=${CXXFLAGS/-fstack-protector-all//}
-       CXXFLAGS=${CXXFLAGS/-fstack-protector//}
+       CFLAGS=${CFLAGS/-fstack-protector-all/}
+       CFLAGS=${CFLAGS/-fstack-protector/}
+       CXXFLAGS=${CXXFLAGS/-fstack-protector-all/}
+       CXXFLAGS=${CXXFLAGS/-fstack-protector/}

        ####################################
        #