Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 107846 - Request to add inter7's qmail-tap patch to qmail
Summary: Request to add inter7's qmail-tap patch to qmail
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Michael Hanselmann (hansmi) (RETIRED)
URL:
Whiteboard:
Keywords: Inclusion
: 108027 253081 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-10-02 00:10 UTC by mike myers
Modified: 2013-05-27 01:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
This is the contents of the file the error message pointed to. (qmail-tap.error,17.60 KB, text/plain)
2005-10-02 00:16 UTC, mike myers
Details
qmail-1.03-r16-tap.diff (qmail-1.03-r16-tap.diff,7.49 KB, patch)
2005-10-04 13:18 UTC, kfm
Details | Diff
Rewrite of inter7's qmail-tap patch (now works with netqmail-1.05-r8) (netqmail-1.05-r8-tap.patch,9.52 KB, patch)
2008-12-05 00:18 UTC, James O'Malley
Details | Diff
Ebuild modified to add tap patch (netqmail-1.06.ebuild,3.43 KB, text/plain)
2012-06-23 02:41 UTC, James O'Malley
Details
Tap patch against netqmail 1.05 (1.06-tap.patch,9.52 KB, text/plain)
2012-06-23 02:42 UTC, James O'Malley
Details
any to cname patch (any-to-cname.patch,399 bytes, text/plain)
2012-06-23 02:45 UTC, James O'Malley
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mike myers 2005-10-02 00:10:45 UTC
I followed the directions in the Gentoo Docs to create an overlay for a custom 
ebuild.  I copied the mail-mta/qmail structure to the /usr/local/portage 
directory, edited the ebuild, digested it, and tried to emerge qmail.

Reproducible: Always
Steps to Reproduce:
1. Create overlay for qmail
2. Edit qmail-1.03-r15.ebuild and digest to include qmail-tap patch
3. copied qmail-tap patch to files/ directory
4. ran 'emerge qmail'

Actual Results:  
 * Applying qmail-tap.diff ...

 * Failed Patch: qmail-tap.diff !
 *  ( /usr/local/portage/mail-mta/qmail/files/qmail-tap.diff )
 *
 * Include in your bugreport the contents of:
 *
 *   /var/tmp/portage/qmail-1.03-r15/temp/qmail-tap.diff-20105.out

Expected Results:  
successfully patched qmail and compiled.

Portage 2.0.51.22-r2 (default-linux/x86/2005.0/2.4, gcc-3.3.6, glibc-2.3.5-r1, 
2.6.12-gentoo-r8 i686)
=================================================================
System uname: 2.6.12-gentoo-r8 i686 Intel(R) Pentium(R) 4 CPU 3.20GHz
Gentoo Base System version 1.6.13
dev-lang/python:     2.2.3-r5, 2.3.5-r2
sys-apps/sandbox:    1.2.10
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6
sys-devel/binutils:  2.15.92.0.2-r10
sys-devel/libtool:   1.5.18-r1
virtual/os-headers:  2.4.19-r1, 2.4.22-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -mcpu=i686 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.1/share/config /usr/kde/
3.2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/
shutdown /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/
kde/3/share/config /usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/
config /var/bind /var/qmail/alias /var/qmail/control /var/vpopmail/domains /var/
vpopmail/etc"
CONFIG_PROTECT_MASK="/etc/gconf /etc/splash /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -mcpu=i686 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks sandbox sfperms strict"
GENTOO_MIRRORS="ftp://ftp.ussg.iu.edu/pub/linux/gentoo http://gentoo.mirrors.
pair.com/ http://gentoo.seren.com/gentoo ftp://gentoo.mirrors.pair.com/ http://
gentoo.ccccom.com"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X aalib alsa apache2 apm arts avi berkdb bitmap-fonts bonobo cdr crypt 
cups curl eds emboss encode esd fam flac foomaticdb fortran gd gdbm gif gnome 
gpm gstreamer gtk gtk2 gtkhtml guile imagemagick imlib java jpeg kde ldap libg++ 
libwww mad maildir mikmod motif mozilla mp3 mpeg mysql ncurses nls ogg oggvorbis 
opengl oss pam pdflib perl png python qt quicktime readline samba sdl slang snmp 
speex spell sqlite sse ssl svga tcltk tcpd tiff truetype truetype-fonts type1-
fonts vorbis xine xml xml2 xmms xv zlib userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS
Comment 1 mike myers 2005-10-02 00:16:18 UTC
Created attachment 69685 [details]
This is the contents of the file the error message pointed to.

This is the contents from the file that the error message pointed to.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2005-10-02 02:28:26 UTC
This is not a bug but a help request. Those belong to forums.gentoo.org or IRC.
Most likely, the patch headers are invalid.

http://dev.gentoo.org/~plasmaroo/devmanual//ebuild-writing/functions/src_unpack/epatch/
Comment 3 kfm 2005-10-03 18:19:38 UTC
*** Bug 108027 has been marked as a duplicate of this bug. ***
Comment 4 mike myers 2005-10-04 07:40:26 UTC
kerframil from irc informed me to reopen this issue and reassign it.
Comment 5 kfm 2005-10-04 13:15:37 UTC
Well yes, I suggested that ... *after* you had figured out how to resolve the
conflicts between the patch and the others applied by the qmail ebuild in its
current form and having given it some testing, yes? A couple of points:

* Jakub originally closed this bug because an inability to apply a patch on top
of a package in its usual form is not the fault of a maintainer, nor is it a bug.

* What you were actually trying to accomplish is to request for a patch to be
added. If it had been stated as such (and marked with a severity level of
enhancement) then it would not have been closed by a bug-wrangler in the first
instance.

* Don't open duplicates please.

Right. I have no clue as to how useful the patch is for your typical qmail user
so I'm not going to make a case for it. What I have done for you though is to
investigate what would be required to integrate the patch. I discovered that it
conflicts with the "qregex-starttls-2way-auth-20050523.patch" because this patch
already supplies the qregex functionality that's required. A cursory glance
suggests to me that the code supplied is identical in both cases. So I've
knocked up a modified version of the tap patch which applies cleanly to the
qmail 1.03-r16 sources in gentoo. WARNING: completely untested, I don't use
qmail any more and it might not even work. It does apply cleanly and the sources
do compile however. I'm attaching the modified patch to this bug. Now you have
something to test :p
Comment 6 kfm 2005-10-04 13:18:49 UTC
Created attachment 69873 [details, diff]
qmail-1.03-r16-tap.diff

Re-diffed instance of Inter7's qmail-tap.diff patch to apply cleanly to a
qmail-1.03-r16 source tree (mainly by removing the qregex stuff). Compile
tested only.
Comment 7 mike myers 2005-10-05 11:50:29 UTC
applied new patch.  it installed and compiled correctly, and seems to be working 
correctly.
Comment 8 kfm 2007-06-17 00:32:34 UTC
OK, this bug is pretty dead. Assigning to the current maintainer of netqmail. If, thereafter, no further comment is forthcoming then I'll mark this as WONTFIX myself.

If the requestor still happens to be on the scene then please note that 3rd party patches can now be applied to mail-mta/netqmail by defining QMAIL_PATCH_DIR in make.conf.
Comment 9 Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2007-06-17 08:05:19 UTC
(In reply to comment #8)
> Assigning to the current maintainer of netqmail.

I'm on qmail-bugs@ …

> If, thereafter, no further comment is forthcoming then I'll mark this as
> WONTFIX myself.

As you already wrote, we don't add custom patches to netqmail. The requester should use QMAIL_PATCH_DIR.
Comment 10 James O'Malley 2008-12-05 00:18:37 UTC
Created attachment 174289 [details, diff]
Rewrite of inter7's qmail-tap patch (now works with netqmail-1.05-r8)

This is a fresh rewrite of inter7's qmail-tap patch.  

To use:
Set QMAIL_PATCH_DIR="/foo/" in make.conf, drop this file in there (I use /usr/src/qmail-patches/), and emerge netqmail.  I haven't tested this patch with the highvolume patches, so I can't guarantee it will work.  I'd appreciate confirmation that it does or does not work with highvolume, but it does work just fine with USE="qmail-spp ssl" on my end.

Please change the status of this bug to RESOLVED, FIXED.
Comment 11 James O'Malley 2012-06-23 02:41:47 UTC
Created attachment 316007 [details]
Ebuild modified to add tap patch

Because the qmail patch directory was deprecated, I had to modify the ebuild directly.
Comment 12 James O'Malley 2012-06-23 02:42:32 UTC
Created attachment 316009 [details]
Tap patch against netqmail 1.05
Comment 13 James O'Malley 2012-06-23 02:45:41 UTC
Created attachment 316011 [details]
any to cname patch

Even though this bug describes issues with the tap patch, I have incorporated the any to cname patch into my ebuild.  This patch is necessary for a lot of US government agencies and older larger organizations.  Qmail won't deliver mail to a lot of organizations without this patch so I consider it mandatory in my qmail setup.
Comment 14 David Sperling 2012-06-23 22:57:22 UTC
Awesome, James.  Thank you for the netqmail-1.06 update.

I've tested the setup on 2 systems and everything seems to be working great.

Here's the step by step for anyone not familiar with the process in gentoo:
http://forums.gentoo.org/viewtopic-p-7069722.html#7069722



Cheers,
Comment 15 James O'Malley 2013-05-27 01:16:52 UTC
*** Bug 253081 has been marked as a duplicate of this bug. ***
Comment 16 James O'Malley 2013-05-27 01:35:56 UTC
Something looks broken on these latest 1.06-r1 builds.  qmail-103.patch has been added to 1.06-r1 and although I haven't confirmed it, it seems to break some things.   I have a bunch of clients running on qmail (netqmail), so I will be taking a look at what's going on here.