Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 107832 - media-sound/imp3sh-0.2.4 bump request
Summary: media-sound/imp3sh-0.2.4 bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Low enhancement (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-01 16:12 UTC by Adrian Frühwirth
Modified: 2007-05-12 18:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
imp3sd-0.2.4.ebuild (imp3sh-0.2.4.ebuild,818 bytes, text/plain)
2006-01-11 21:14 UTC, Thomas Cort (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Frühwirth 2005-10-01 16:12:06 UTC
Version 0.2.4 out since Juli 2004, see ChangeLog (http://www.geocities.com/
kman_can/CHANGES-024.txt).
Comment 1 Jeremy Huddleston (RETIRED) gentoo-dev 2005-10-16 13:55:36 UTC
This requires libxaudio for me to test on amd64 (which is a binary), and I
didn't add the package initially, so bumping to sound herd
Comment 2 Thomas Cort (RETIRED) gentoo-dev 2006-01-11 21:14:48 UTC
Created attachment 76881 [details]
imp3sd-0.2.4.ebuild

Attached is an ebuild copied from imp3sh-0.2.3.ebuild with the following changes...

The old ebuild had:
DEPEND="sys-libs/ncurses
     vorbis? ( media-libs/libvorbis
               media-libs/libao )"

The new ebuild has:
DEPEND="sys-libs/ncurses
        media-libs/libvorbis
        media-libs/libogg
        media-libs/libao"

Added libogg to DEPEND (it was missing[1]). Removed IUSE="vorbis" as running
`USE="-vorbis" emerge imp3sh` will still compile with vorbis support (assuming you have libvorbis libogg libao installed) because there is no enable/disable configure option for vorbis support.


The old ebuild had:
KEYWORDS="x86"

The new ebuld has:
KEYWORDS="-* ~x86"

This is done as the libxaudio[2] library included in the package is an x86 binary (ie you cannot compile this program on non-x86). Binaries for other arches exist, but if Gentoo wanted to distribute the library for other archs as a separate package, there would be license fees[3].

Related to the Xaudio library, I think that there might be a GPL violation here. imp3sh is LICENSE="GPL-2", but Xaudio is GPL-incompatible and doesn't fit the  "from major parts of a proprietary operating system" exception in the GPL, nor can I find a "permission to link" exception from the copyright holder. See the GPL FAQ[4] for more info.


When emerging imp3sh-0.2.4 with this ebuild I got the following QA Notice:
QA Notice: the following files contain executable stacks
 Files with executable stacks will not work properly (or at all!)
 on some architectures/operating systems.  A bug should be filed
 at http://bugs.gentoo.org/ to make sure the file is fixed.
RWX --- --- usr/bin/imp3sh

I followed the GNU Stack QuickStart[5], but I was not able to find/fix the problem.  
imp3sh-0.2.4 # scanelf -qeR .
RWX --- ---  ./work/imp3sh-0.2.4/imp3sh


I haven't done much testing of the program itself as my x86 box has no sound card presently (I'm working to fix that ;), and I couldn't test it on my ppc, alpha, or sparc32 boxes because of the Xaudio library.


[1] List of dependencies at the bottom of the page
http://www.geocities.com/kman_can/

[2] Xaudio Homepage
http://xaudio.com

[3] Xaudio License Request Page
http://www.xaudio.com/license_request.html

[4] GNU GPL FAQ Linking GPL programs with GPL incompatible libraries
http://www.gnu.org/licenses/gpl-faq.html#GPLIncompatibleLibs

[5] Gentoo GNU Stack QuickStart
http://www.gentoo.org/proj/en/hardened/gnu-stack.xml
Comment 3 Steve Dibb (RETIRED) gentoo-dev 2007-05-12 18:31:35 UTC
in CVS, thanks for the ebuild