107430 – [gcc4] pam and shadow not compiling due to pam headers problem

Bug 107430 - [gcc4] pam and shadow not compiling due to pam headers problem

Summary: [gcc4] pam and shadow not compiling due to pam headers problem

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] GCC Porting (show other bugs)
Hardware:	PPC64 Linux

Importance:	High enhancement (vote)
Assignee:	PAM Gentoo Team (OBSOLETE)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	117482
	Show dependency tree

Reported:	2005-09-27 11:57 UTC by Markus Rothe (RETIRED)
Modified:	2006-01-12 01:10 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
pam-0.78-r2.txt (pam-0.78-r2.txt,4.02 KB, text/plain) 2005-09-27 11:58 UTC, Markus Rothe (RETIRED)	Details
shadow-4.0.7-r3.txt (shadow-4.0.7-r3.txt,5.26 KB, text/plain) 2005-09-27 11:58 UTC, Markus Rothe (RETIRED)	Details
/usr/include/asm-ppc64/types.h (types.h,1.75 KB, text/plain) 2005-09-27 11:59 UTC, Markus Rothe (RETIRED)	Details
pam fix (pam-header.patch,618 bytes, patch) 2006-01-11 17:31 UTC, Mark Loeser (RETIRED)	Details \| Diff
shadow fix (shadow-4.0.7-headers.patch,2.89 KB, patch) 2006-01-11 17:31 UTC, Mark Loeser (RETIRED)	Details \| Diff
new and improved pam fix :) (pam-header.patch,459 bytes, patch) 2006-01-11 20:12 UTC, Mark Loeser (RETIRED)	Details \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Markus Rothe (RETIRED) gentoo-dev

2005-09-27 11:57:44 UTC

Hi,

pam-0.78-r2 and shadow-4.0.7-r3 do not compile using gcc-4.0.1. output follows.

Markus

Comment 1 Markus Rothe (RETIRED) gentoo-dev

2005-09-27 11:58:08 UTC

Created attachment 69360 [details]
pam-0.78-r2.txt

Comment 2 Markus Rothe (RETIRED) gentoo-dev

2005-09-27 11:58:25 UTC

Created attachment 69361 [details]
shadow-4.0.7-r3.txt

Comment 3 Markus Rothe (RETIRED) gentoo-dev

2005-09-27 11:59:41 UTC

Created attachment 69362 [details]
/usr/include/asm-ppc64/types.h

Comment 4 Tim Yamin (RETIRED) gentoo-dev

2005-12-22 15:16:31 UTC

Want to try this again with a newer gcc-4 (4.1.0_beta, maybe)?

Comment 5 Markus Rothe (RETIRED) gentoo-dev

2005-12-23 02:09:29 UTC

same result using 4.1.0-beta20051216

Comment 6 Mark Loeser (RETIRED) gentoo-dev

2006-01-11 17:30:16 UTC

Both of these occur for the same reason.  A user space header is defining __u8 before asm/types.h is pulled in.  Just need to reorder the includes so this happens.

Comment 7 Mark Loeser (RETIRED) gentoo-dev

2006-01-11 17:31:30 UTC

Created attachment 76871 [details, diff]
pam fix

Comment 8 Mark Loeser (RETIRED) gentoo-dev

2006-01-11 17:31:54 UTC

Created attachment 76872 [details, diff]
shadow fix

Comment 9 Mark Loeser (RETIRED) gentoo-dev

2006-01-11 17:32:27 UTC

base-system and pam-bugs, please apply the patch for your app.  Thanks :)

Comment 10 SpanKY gentoo-dev

2006-01-11 17:56:31 UTC

i dont like it at all

Comment 11 Mark Loeser (RETIRED) gentoo-dev

2006-01-11 19:36:50 UTC

Yea, this way does suck.  I'll just fix the pam header.

Comment 12 Mark Loeser (RETIRED) gentoo-dev

2006-01-11 20:12:04 UTC

Created attachment 76877 [details, diff]
new and improved pam fix :)

Since our pam is linux only, I can go ahead and just include asm/types.h, as far as I know.

Comment 13 Diego Elio Pettenò (RETIRED) gentoo-dev

2006-01-12 00:10:49 UTC

Actually, pam works fine on gcc4 on amd64.
Can someone point why ppc64 and amd64 differs?

Comment 14 Diego Elio Pettenò (RETIRED) gentoo-dev

2006-01-12 01:10:57 UTC

Okay added a patch that should fix this.