Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 106799 - Patch to fix issue with horde-imp under php 5.0.5
Summary: Patch to fix issue with horde-imp under php 5.0.5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Web Application Packages Maintainers
URL:
Whiteboard:
Keywords:
: 106961 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-09-21 07:49 UTC by Ronald Hummelink
Modified: 2005-10-25 06:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix mailbox.php (imp-4.0.3-mailbox.php-php-5.0.5.patch,632 bytes, patch)
2005-09-21 07:50 UTC, Ronald Hummelink
Details | Diff
double submit/mispaste (imp-4.0.3-message.php-php-5.0.5.patch,656 bytes, patch)
2005-09-23 02:00 UTC, Ronald Hummelink
Details | Diff
imp-4.0.3-message.php-php-5.0.5.patch (imp-4.0.3-message.php-php-5.0.5.patch,656 bytes, patch)
2005-09-23 02:00 UTC, Ronald Hummelink
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ronald Hummelink 2005-09-21 07:49:28 UTC
php devs broke compatibility, making horde-imp break

I wish i knew a nice way to search for foxes in horde cvs, if I find more issues
running horde, i will attach more patches...


Reproducible: Always
Steps to Reproduce:
Comment 1 Ronald Hummelink 2005-09-21 07:50:06 UTC
Created attachment 68938 [details, diff]
fix mailbox.php
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2005-09-23 01:56:10 UTC
*** Bug 106961 has been marked as a duplicate of this bug. ***
Comment 3 Ronald Hummelink 2005-09-23 02:00:08 UTC
Created attachment 69056 [details, diff]
double submit/mispaste
Comment 4 Ronald Hummelink 2005-09-23 02:00:26 UTC
Created attachment 69057 [details, diff]
imp-4.0.3-message.php-php-5.0.5.patch
Comment 5 Ronald Hummelink 2005-09-23 02:10:14 UTC
One dev tells me to keep issues seperate, the other marks them duplicate... i
will never learn :P
Comment 6 Canal Vorfeed 2005-09-23 12:34:22 UTC
Do we even want to fix this in horde-imp, phpBB and elsewhere ? Not just
horde-imp is affected - I think it's easier to find unaffected package!

http://cvs.php.net/diff.php/ZendEngine2/zend_execute.c?r1=1.652.2.39&r2=1.652.2.53&ty=u
This "fix" not only broke huge number of packages BUT also forced error messages
in some supposedly correct constructs!

http://cvs.php.net/diff.php/ZendEngine2/zend_execute.c?r1=1.652.2.39&r2=1.652.2.53&ty=u
As you can see there are some changes in PHP_5_0 branch to fix further. May be
it's better to just rollback this change for PHP 5.0.5 and check if PHP 5.0.6 is
any better ?

PHP 5.0.5 is supposed to be minor bugfix release for god's sake and this change
DOES break existing programs as masse AND can not make any formally invalid
program correct - hardly a "bugfix" to me.
Comment 7 Canal Vorfeed 2005-09-23 12:36:26 UTC
Oops. Copy-paste error. Correct URL was problematic change is
http://cvs.php.net/diff.php/ZendEngine2/zend_execute.c?r1=1.652.2.38&r2=1.652.2.39&ty=u
of course...
Comment 8 Jakub Moc (RETIRED) gentoo-dev 2005-09-23 12:43:33 UTC
(In reply to comment #6)
> PHP 5.0.5 is supposed to be minor bugfix release for god's sake and this change
> DOES break existing programs as masse AND can not make any formally invalid
> program correct - hardly a "bugfix" to me.

Direct your comments upstream, Gentoo did not change this and you are really
moaning on a wrong grave. Meanwhile, you can use 4.3.11 or 5.0.4.
Comment 9 Luca Longinotti (RETIRED) gentoo-dev 2005-09-23 12:45:37 UTC
> PHP 5.0.5 is supposed to be minor bugfix release for god's sake and this change
> DOES break existing programs as masse AND can not make any formally invalid
> program correct - hardly a "bugfix" to me.

We know, that's exactly why we still provide 5.0.4, and 4.3.11. 4.4.0 and 5.0.5
broke much PHP applications, 5.0.6 will another time change stuff, but upstreams
answer is "Fix your scripts! We do not care, the fix on our part was needed!",
so we can hardly do something about it, and it's not possible to now backport
and exchange the ZendEngine across releases just because, if you need working
scripts, use 5.0.4, that's all we can provide. Our policy is to release mostly
"vanilla" versions of PHP, fixing security issues and providing any ebuild
needed if backwards compatibility is broken (like 5.0.4 --> 5.0.5, we still have
and maintain 5.0.4). Other than that we can't do much, working on the
ZendEngine, seeing what do and what not to backport etc. is totally out of our
scope and possibilities, only for the immense amount of maintainance such a
thing would require and the knowledge in C and the inner workings of the
ZendEngine required.
Best regards, CHTEKK.
Comment 10 SpanKY gentoo-dev 2005-10-24 20:09:01 UTC
where did these patches come from ?  i'm only interested in adding patches which
come from upstream horde CVS/bugzilla/devs ...
Comment 11 Ronald Hummelink 2005-10-24 22:06:47 UTC
It came from CVS, but its useless now, as imp has a new release, which i would
be suprised if it didn't have these fixes.

IMP H3 (4.0.4) (October 17 2005)
Comment 12 SpanKY gentoo-dev 2005-10-25 06:21:39 UTC
sounds good
Comment 13 SpanKY gentoo-dev 2005-10-25 06:22:49 UTC
.
Comment 14 SpanKY gentoo-dev 2005-10-25 06:23:16 UTC
i added latest horde-imp to portage yesterday