Bug 106697 – amule 2.0.3-r2 broken

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Giacomo Perale 2005-09-20 09:46:26 UTC]

In a (clumsy) attempt to comply with the new policy on gtk/gtk2 USE-flags,
someone broke amule 2.0.3-r2. The ebuild used the wxwidget eclass to choose the
correct version of wxGTK 2.6.1, and the line 'need-wxwidgets gtk2' was needed to
use gtk2-enabled wxGTK, the default option with wxGTK >= 2.6 (required by the
ebuild).

Now someone changed 'gtk2' in 'gtk', and the ebuild fails when it tries to use
the gtk1 support that is compiled only when expressly required by the specific
wxGTK local flag 'wxgtk1' and not by default.

Also, the new check:

        need-wxwidgets gtk
        use unicode && need-wxwidgets unicode

is meaningless, because 'need-wxwidgets unicode' doesn't override
'need-wxwidgets gtk'.

Solution: remove 'gtk' from the ebuild use-flag list ('maintainer knows better'
in the best of all worlds), and change the mentioned lines in:

        if use unicode; then
                need-wxwidgets unicode
        else
                need-wxwidgets gtk2
        fi

[Comment 1 Marcin Kryczek (RETIRED) 2005-09-20 10:18:39 UTC]

yep - my mistake. sorry for that and thanks for reporting. fixed in cvs

[Comment 2 Diego Elio Pettenò (RETIRED) 2005-09-21 12:01:18 UTC]

Something slipped through here. 
 
I know I did add support to build amule _without x compiled_ at all... 
That is needed if you want to use amuled in a non-x installation. 

[Comment 3 Marcin Kryczek (RETIRED) 2005-09-22 15:39:37 UTC]

thanks Diego. i hope this one would be correct at least.