Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 106554 - net-nds/gq: wrong dep on gdk-pixbuf
Summary: net-nds/gq: wrong dep on gdk-pixbuf
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 122336
  Show dependency tree
 
Reported: 2005-09-19 11:16 UTC by TGL
Modified: 2006-03-25 22:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
gq-1.0_beta1-r2.ebuild (gq-1.0_beta1-r2.ebuild,1.67 KB, text/plain)
2006-02-09 14:16 UTC, Greg Watson (linuxkrn)
Details
gq-1.0_beta1-r2.ebuild patch (gq-1.0_beta1-r2.ebuild.diff,777 bytes, patch)
2006-02-10 00:54 UTC, Jakub Moc (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description TGL 2005-09-19 11:16:31 UTC
This package lists media-libs/gdk-pixbuf in its dependencies, but actually links
against libgdk-pixbuf-2.0.so, which is provided by x11-libs/gtk+-2.x. This wrong
dependency prevents installing this package on systems which don't have GTK+-1.x.
Comment 1 Greg Watson (linuxkrn) 2006-02-09 14:16:01 UTC
Created attachment 79377 [details]
gq-1.0_beta1-r2.ebuild

I think this should fix your problems.  gtk+2 provides pixbuf for jpeg support, but if you want jpeg support and use gtk+1 then you need gdk-pixbuf.

Changed RDEPEND="
gtk? (
        !gtk2? ( 
                >=x11-libs/gtk+1
                jpeg? ( media-libs/gtk-pixbuf )
               )
        gtk2? ( >=x11-libs/gtk+-2 )
    )
    ...

This worked for me, but I have gtk+2, so if you could test with -gtk2 +gtk +jpeg?
Comment 2 TGL 2006-02-09 19:03:49 UTC
The gtk2 flag has been deprecated some time ago. Afaik, the policy is to enforce whatever is the "best" branch for the package. Only the "gtk" flag remains, but it's for selection of optional gtk support, which is not the case here.

So, the correct fix would rather be to make the ebuild depend on gtk2 only, unconditionally. On 1.0-beta-r1, it is:
 - drop "jpeg? ( media-libs/gdk-pixbuf )" from the deps
 - drop the "jpeg" flag from IUSE
 - add version to the glib dep
 - drop the atk-1 dep
(And in addition, drop the bunch of system packages from the deps.)

But anyway, we are talking about an unmaintained ebuild for an unmaintained application, so i'm not sure it really matters :)
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2006-02-10 00:54:53 UTC
Created attachment 79413 [details, diff]
gq-1.0_beta1-r2.ebuild patch

OK, so:

- dropped jpeg USE flag and bogus media-libs/gdk-pixbuf dependency
- dropped dev-libs/atk-1 dep
- dropped implicit system deps (gcc, bison, gawk)
- dropped bogues sys-devel/gettext dependency. This ebuild uses bundled gettext implementation, so it's redundant. If system gettext is preferable, then --with-included-gettext needs to be dropped from src_compile()
- changed glib dep to >=dev-libs/glib-2
Comment 4 Mark Loeser (RETIRED) gentoo-dev 2006-03-25 22:20:35 UTC
This package has been removed from the tree.