Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 106112 - start-stop-daemon.c wont compile on Gentoo/NetBSD
Summary: start-stop-daemon.c wont compile on Gentoo/NetBSD
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Other
: High enhancement
Assignee: Gentoo/BSD Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-15 14:02 UTC by Damian Florczyk
Modified: 2006-04-12 10:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ssd-netbsd.patch (ssd-netbsd.patch,1.65 KB, patch)
2005-09-15 18:30 UTC, SpanKY
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Damian Florczyk 2005-09-15 14:02:21 UTC
start-stop-daemon.c wont compile on Gentoo/NetBSD because there are some
missmatches betwen <sys/proc.h> (tested on baselayout-1.12.0_pre8) but NetBSD
has been included to if statment with FreeBSD and OpenBSD (i think this statment
wont work with obsd but i'm just guessing)

Diffs:
There is no ki_* (eg. ki_rpid) in kinfo_proc structure but there is p_* (eg.
p_rpid) in kinfo_proc2 struct.


here is patch for baselayout-1.12.0_pre8 to be applied on src/start-stop-daemon.c
http://thunder.netbsd.edu.pl/netbsd-baselayout-1.12.0_pre8.patch

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 SpanKY gentoo-dev 2005-09-15 18:30:39 UTC
Created attachment 68550 [details, diff]
ssd-netbsd.patch

so you duplicated all that code just because two structs have slightly
different names and slightly different members ?  what about this much simpler
(and untested) patch ?
Comment 2 Damian Florczyk 2005-09-16 01:13:20 UTC
SpanKY it also works. Thx. I've created new 'if' statements for NetBSD cause
i've thought that there will be more changes.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-09-17 01:51:11 UTC
Works fine on G/FBSD too, patch applied to bsd-porting branch of baselayout. 
 
Mike can you move that to trunk, and then close the bug? 
Comment 4 SpanKY gentoo-dev 2005-09-17 15:47:29 UTC
done, thanks