Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 105723 - dev-util/quilt should depend on sys-apps/ed
Summary: dev-util/quilt should depend on sys-apps/ed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor
Assignee: Aaron Walker (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-12 12:40 UTC by Torne Wuff
Modified: 2005-09-14 18:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Torne Wuff 2005-09-12 12:40:26 UTC
quilt's annotate command generates ed-style patches to create its output. The
patch command from diffutils doesn't know how to apply them itself, and doesn't
depend on ed as it's such a rare thing to want to do these days ;)

Thus, it'd be nice if quilt depended on ed as well as diffstat/diffutils, to
allow for this.

Reproducible: Always
Steps to Reproduce:
Comment 1 Aaron Walker (RETIRED) gentoo-dev 2005-09-14 13:30:32 UTC
Since ed is not really a dependency (at least I could not find a place where ed
is invoked -- please point it out and reopen this if I am wrong), it doesn't
really make sense to add it.

As far as diffstat/diffutils, diffstat is already a listed dependency and
diffutils is an implicit dependency (it's in the 'system' target).
Comment 2 Torne Wuff 2005-09-14 16:08:01 UTC
I know it already depends on diffstat (and indirectly diffutils). ed is not
directly anywhere, but /usr/share/quilt/annotate invokes patch on line 154,
feeding it ed-format diff output on stdin. The patch manpage states that
ed-format patches are simply piped to ed, but in practise it promptly fails as
ed is not installed.

quilt's annotate output is the first place I've seen ed-format patches in a good
six, seven years..

Yes, it's not a direct dependency, but since ed support is an optional feature
in patch, there's nothing else that's gonna install it.. and it took me a while
to figure out why no line annotations were being inserted (as my editor was
helpfully discarding quilt's stderr and only showing me the stdout, which, if
patch can't do the operation, is just a copy of the input file with no annotations).

So, err, close this again if you want, I guess, but I do think ed should be
included as a dependency of either quilt or diffutils, and if it's added to the
latter I can imagine plenty of people will promptly bitch about ed appearing on
their systems, as they have absolutely no use for it ;)
Comment 3 Aaron Walker (RETIRED) gentoo-dev 2005-09-14 18:34:46 UTC
Ok the way you worded it this time makes much more sense.  Deps have been
updated in cvs.