Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 105693 - dev-util/catalyst: please add sh arch
Summary: dev-util/catalyst: please add sh arch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Catalyst Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-12 08:06 UTC by MATSUU Takuto (RETIRED)
Modified: 2005-09-13 08:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
catalyst-sh.patch (catalyst-sh.patch,2.64 KB, patch)
2005-09-12 08:07 UTC, MATSUU Takuto (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description MATSUU Takuto (RETIRED) gentoo-dev 2005-09-12 08:06:08 UTC
catalyst works fine on my sh arch with this patch. 
Please apply this patch and add sh to KEYWORDS.
Comment 1 MATSUU Takuto (RETIRED) gentoo-dev 2005-09-12 08:07:00 UTC
Created attachment 68253 [details, diff]
catalyst-sh.patch
Comment 2 Chris Gianelloni (RETIRED) gentoo-dev 2005-09-12 08:32:05 UTC
Added to CVS HEAD... (catalyst 2)
Comment 3 SpanKY gentoo-dev 2005-09-12 16:05:07 UTC
it should also declare CXXFLAGS in there ...
Comment 4 Chris Gianelloni (RETIRED) gentoo-dev 2005-09-13 04:18:12 UTC
Should they be the same as CFLAGS or is there anything special for sh for C++?
Comment 5 SpanKY gentoo-dev 2005-09-13 05:58:44 UTC
just set em equal
Comment 6 Chris Gianelloni (RETIRED) gentoo-dev 2005-09-13 08:26:37 UTC
<wolf31o2-work> rocket: how does CXXFLAGS normally get set in catalyst? does it
normally copy CFLAGS?
<rocket> let me double check .. it might
<wolf31o2-work> ok
<rocket> look at the hppa.py is a way to override it
<wolf31o2-work> reason I ask is because of bug #105693 where they're asking to
have CFLAGS defined...
<jeeves> wolf31o2-work: http://bugs.gentoo.org/show_bug.cgi?id=105693 enh, P2,
All, matsuu@gentoo.org->catalyst@gentoo.org, ASSIGNED, pending,
dev-util/catalyst: please add sh arch
<wolf31o2-work> but I'm noticing that most arches do *not* have it defined
<rocket> if self.settings.has_key("CXXFLAGS"):
<rocket>                            
myf.write('CXXFLAGS="'+self.settings["CXXFLAGS"]+'"\n')
<rocket>                     else:
<rocket>                             myf.write('CXXFLAGS="${CFLAGS}"\n')
<rocket> it will use CFLAGS by default
<wolf31o2-work> what file is that in?
<wolf31o2-work> nevermind
<wolf31o2-work> modules/generic_stage_target.py

Anyway, if you have CXXFLAGS that are different from CFLAGS, then I'll add them,
otherwise catalyst already sets them to be equivalent.
Comment 7 SpanKY gentoo-dev 2005-09-13 08:47:09 UTC
sounds good, thanks