Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 105676 - app-mobilephone/yaps - Expand yaps.rc by Service Cityruf
Summary: app-mobilephone/yaps - Expand yaps.rc by Service Cityruf
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Gentoo Mobile Phone Developers (INACTIVE)
URL:
Whiteboard:
Keywords:
: 105677 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-09-12 05:49 UTC by Rafael Kolless
Modified: 2005-10-18 14:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patchfile to yaps.rc to extend it for the service Cityruf (yaps.rc.patch,903 bytes, patch)
2005-10-13 10:17 UTC, Rafael Kolless
Details | Diff
yaps-0.96-gentoo.patch-15280.out (yaps-0.96-gentoo.patch-15280.out,7.47 KB, text/plain)
2005-10-15 04:42 UTC, Stefan Briesenick (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Kolless 2005-09-12 05:49:11 UTC
Could you expand the yaps.rc by this entry:

[Cityruf]
protocol       tap
valid-pid      0168|0164
change-pid     -
convert        *no-8bit,cv-default,cv-extend
phone          016902
max-size       80
use-call-id            False
insert-pager-id        False
truncate       True

The Cityruf is missing in the original yaps.rc

Reproducible: Always
Steps to Reproduce:
1. n/a
2.
3.



Expected Results:  
Native support of Cityruf by yaps
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2005-09-12 05:55:17 UTC
*** Bug 105677 has been marked as a duplicate of this bug. ***
Comment 2 Rafael Kolless 2005-10-05 13:13:16 UTC
does noone maintain this package anymore? 
 
I received no answers at all. Is a maintainer neeeded? 
Comment 3 Alin Năstac (RETIRED) gentoo-dev 2005-10-05 14:49:56 UTC
I will fix it when I'll have the time. right now I'm pretty busy in real life as
well as in gentoo life.
don't worry, the next version will have this entry in yaps.rc.
Comment 4 Alin Năstac (RETIRED) gentoo-dev 2005-10-05 23:03:39 UTC
please attach the patch
Comment 5 Alin Năstac (RETIRED) gentoo-dev 2005-10-12 13:30:56 UTC
Please attach a patch. 
I'm not sure where should I include this section (yaps.rc sounds like gibberish
to me).
Comment 6 Rafael Kolless 2005-10-13 10:17:43 UTC
Created attachment 70578 [details, diff]
Patchfile to yaps.rc to extend it for the service Cityruf

sorry for the delay, I was quite busy the last days.

This is my first patchfile so I hope I made it correct.
Comment 7 Alin Năstac (RETIRED) gentoo-dev 2005-10-15 00:58:24 UTC
fixed in yaps-0.96-r1
Comment 8 Stefan Briesenick (RETIRED) gentoo-dev 2005-10-15 04:38:48 UTC
>>> Unpacking yaps-0.96.c2.tgz to /var/tmp/.gentoo/portage/yaps-0.96-r1/work 
 * Applying yaps-0.96-gentoo.patch ... 
 
 * Failed Patch: yaps-0.96-gentoo.patch ! 
 *  ( /usr/portage/app-mobilephone/yaps/files/yaps-0.96-gentoo.patch ) 
 * 
 * Include in your bugreport the contents of: 
 * 
 
*   /var/tmp/.gentoo/portage/yaps-0.96-r1/temp/yaps-0.96-gentoo.patch-15280.out 
 
Comment 9 Stefan Briesenick (RETIRED) gentoo-dev 2005-10-15 04:42:25 UTC
Created attachment 70721 [details]
yaps-0.96-gentoo.patch-15280.out

hmmm. this package worked in the past.
Comment 10 Alin Năstac (RETIRED) gentoo-dev 2005-10-16 00:03:01 UTC
hmm... work as expected on my machine:
ss@alin ~/gentoo-cvs/app-mobilephone/yaps $ ebuild yaps-0.96-r1.ebuild unpack
>>> md5 files   ;-) yaps-0.96.ebuild
>>> md5 files   ;-) yaps-0.96-r1.ebuild
>>> md5 files   ;-) files/yaps-0.96.patch
>>> md5 files   ;-) files/digest-yaps-0.96-r1
>>> md5 files   ;-) files/yaps-0.96-gentoo.patch
>>> md5 files   ;-) files/digest-yaps-0.96
>>> md5 files   ;-) files/yaps-0.96-capiv3.patch
>>> md5 src_uri ;-) yaps-0.96.tar.gz
>>> Unpacking source...
>>> Unpacking yaps-0.96.tar.gz to /var/tmp/portage/yaps-0.96-r1/work
 * Applying yaps-0.96-gentoo.patch ...                                         
                              [ ok ]
 * Converting 'yaps.doc' to UTF-8
>>> Source unpacked.
Comment 11 Stefan Briesenick (RETIRED) gentoo-dev 2005-10-16 05:52:53 UTC
no, even after "emerge sync", your patch is still broken. 
but the old app-mobilephone/yaps-0.96 works perfectly. 
 
Comment 12 Stefan Briesenick (RETIRED) gentoo-dev 2005-10-16 05:54:58 UTC
please try USE-flag "capi" also, since it uses a different source-package! 
 
Comment 13 Stefan Briesenick (RETIRED) gentoo-dev 2005-10-16 05:58:37 UTC
I try to fix the patch-file. 
 
Comment 14 Stefan Briesenick (RETIRED) gentoo-dev 2005-10-16 06:10:19 UTC
ok, I found the error. You moved the cd ${S}, while your patch includes the 
basedir of the non-capi yaps. The capi-yaps has a different basedir! The 
original patch had no paths included for this specific reason. 
 
I will fix it! But next time, please check the ebuild with every USE flag if 
you modified it. Thanks. 
 
Comment 15 Stefan Briesenick (RETIRED) gentoo-dev 2005-10-16 06:48:46 UTC
ok, fixed ebuild & patch in portage now. 
 
Comment 16 Alin Năstac (RETIRED) gentoo-dev 2005-10-16 22:17:59 UTC
(In reply to comment #14)
> I will fix it! But next time, please check the ebuild with every USE flag if 
> you modified it. Thanks. 
>  

hmmm... I don't think you could abuse of use function like that:
use capi && S="${S}.c2"

If I remember correctly, we are not allowed to call functions in global scope,
not to mention the S="${S}.c2" that could lead to nasty side effects if is
interpreted more than once.
Instead, you should do:
pkg_setup() {
   if use capi ; then
     S="${WORKDIR}/${P}.c2"
   fi
}
Comment 17 Stefan Briesenick (RETIRED) gentoo-dev 2005-10-17 13:39:13 UTC
no problem, I can fix this. But it has basically the same result then. 
So your patch would fail nonetheless. No matter where I place this command. 
Problem is, that I have to use 2 different source-packages, which contain 
different base dirs. The more ugly option would be to split this into two 
ebuilds. 
 
Comment 18 Stefan Briesenick (RETIRED) gentoo-dev 2005-10-17 15:02:05 UTC
pkg_setup() doesn't work for me. ${S} is always reset to the global value. I 
have to solve it (more ugly) differently. 
 
Comment 19 Stefan Briesenick (RETIRED) gentoo-dev 2005-10-17 15:26:53 UTC
ok, fixed in portage. 
 
Comment 20 Alin Năstac (RETIRED) gentoo-dev 2005-10-18 00:55:44 UTC
what about this solution:
pkg_unpack() {
  unpack ${A}
  if use capi ; then
    mv ${S}.c2 ${S}
  fi
}

seems a better way of dealing with different $S
Comment 21 Stefan Briesenick (RETIRED) gentoo-dev 2005-10-18 06:51:06 UTC
should be possible. I change this later, though I have a working solution now. 
nonetheless, I still don't understand why you included the base path in the 
patchfile. 
 
Comment 22 Stefan Briesenick (RETIRED) gentoo-dev 2005-10-18 14:07:59 UTC
modified version is in portage now. 
Comment 23 Alin Năstac (RETIRED) gentoo-dev 2005-10-18 14:32:15 UTC
(In reply to comment #21)
> nonetheless, I still don't understand why you included the base path in the 
> patchfile. 

I always generate patches by running diff -Nru foo.orig foo, where foo is the
source directory.