Please find attached chemtool.tar.bz2, containing an ebuild for chemtool-1.5 and various patches to help it build Gentoo-ly. From chemtool's Web page: Chemtool is a program for drawing organic molecules Filing it under app-sci/chemtool seems reasonable -- marshall t. vandegrift (vandem2@rpi.edu)
Created attachment 5564 [details] chemtool-1.5 ebuild and patches
Hi Marshall. Thank you for your submission! Unfortunately there are few problems that have to be sorted out: 1. Please convert patches to a unified diff format (diff -u). 2. It is not very good to force C[XX]FLAGS to a strictly set value unless absolutely necessary. More importantly, forcing them via patch is unnecessary (the patch to Makefie.in). Please try to use the provided eclass: flag-o-matic. You can take a look at the eclass itself for the definition and description of all the provided functions. You can also grep through ebuilds for the examples (filter-flags is the most often used function which is designed to remove some problematic setting from C[XX]FLAGS). 3. The configure script apparently ignores --without-kdedir flag (it still autodetects kde and sets the patch correspondingly). Something should be done anout it. 4. In present form ebuild halts during src_install reporting SANDBOX_VIOLATIOn - the is trying to write to the live filesystem instead of under ${D}. I corrected installation of locales, however the kde issue is not so easy. Could you please polish it a bit? (In order to see sandbox violation complaints you need to have "sandbox" in the FEATURES in your make.conf). I am attaching the modified ebuild to the bug. George
Created attachment 5597 [details] chemtool-1.5.ebuild Modified ebuild chemtool-1.5.ebuild
Created attachment 5598 [details] ChangeLog So that I don't loose it :).
Hi George, Thanks for your feedback. :-) This ebuild represents the first (manual) step towards automating the process of converting FreeBSD ports to Gentoo ebuilds (not that I want to plague Gentoo with FreeBSD's ports problems... It just seems like it might be useful). Anyway, if I'd been more careful, I would have started with a package not as hopelessly b0rked as this one... Pertinant to your specific comments: 1. All diffs now in unified format. Sorry 'bout that. 2. My patches *stop* the Makefile.ins from hard-coding CFLAGS, so no problems. :-) On the other hand, thank you for the suggestion that I look at possibly applicable eclasses... 3. Fixed. Ugh. My patches are almost complete re-writes of the affected files. As one bright point, it turns out that an appropriate KDE directory can be autodetected using the 'need-kde' function in the 'kde-functions' eclass. 4. I do have sandbox turned on. This only popped up if GNOME or KDE support were enabled, which I just assumed would work (BAD IDEA, I know... I won't do it in the future). Whew. Updated ebuild and patches in following attachment. -- marshall t. vandegrift (vandem2@rpi.edu)
Created attachment 5629 [details] updated chemtool-1.5 ebuild and patches
Hi Marshall. Thanks for the update, this looks good now ;). I did few minor clean-ups and committed the ebuild. Please test. George
