Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 105069 - enhancement request for cfg-update (script doesnt like spaces and quotation marks)
Summary: enhancement request for cfg-update (script doesnt like spaces and quotation m...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Third-Party Tools (show other bugs)
Hardware: AMD64 Linux
: High minor (vote)
Assignee: Harald van Dijk (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-06 14:57 UTC by Attila Stehr
Modified: 2005-09-16 13:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Attila Stehr 2005-09-06 14:57:44 UTC
magic atti # cat /etc/make.conf
CHOST           ="x86_64-pc-linux-gnu"
CFLAGS          ="-march=athlon64 -O3 -pipe -fomit-frame-pointer"
#CFLAGS         ="-march=athlon64 -O1 -pipe -fomit-frame-pointer -g -ggdb3"
CXXFLAGS        ="${CFLAGS}"
#LDFLAGS        ="-Wl,-O1"

MAKEOPTS        ="-j2"
FEATURES        ="candy severe sfperms test"
# FEATURES      ="candy severe sfperms"

PORT_LOGDIR     ="/var/log/portage"

# we have: amd64
# graphics: dga gnome gtk gtk2 opengl svga X
# x-specific: dlloader xprint
# gnome specific: dbus hal howl
# mplayer specific: dvdread encode matroska sdl
# firefox: mozdevelop mozsvg -java -mozilla mozcalendar
# printing: cups, foomaticdb, gimpprint, ppds
# misc hardware: acpi cdr dvd dvdr usb
# compression support: bzlib lzo
# language support: nls unicode
# sound: aac alsa audiofile dts flac libsamplerate sndfile
# audio support: mikmod oggvorbis openal
# image support: gif jpeg jpeg2k mng png svg tga yv12 openexr ... exif
# video support: avi mjpeg mpeg quicktime real xvid xvmc ffmpeg theora
# more security: hardened memlimit pam ssl tcpd
# links2 specific: directfb fbcon javascript
# misc sw: crypt emacs on-the-fly-crypt pda pdflib tidy truetype videos lcms
sysfs tetex toolbar xmms xtermtoolbar
# performance: 3dnowext nvidia   mmap ithreads nptl threads
# quality: mad
# always test: test
# always update kernel: symlink
# nptlonly
# FS: fat, ntfs, reiserfs
# other: a52 dpms dmalloc fame firefox mpi

USE             ="amd64 3dnowext a52 aac acpi alsa audiofile avi bzlib cdr crypt
cups dbus dga directfb dlloader dmalloc dpms dts dvd dvdr dvdread emacs encode
exif fame fat fbcon ffmpeg firefox flac foomaticdb gif gimpprint gnome gtk gtk2
hal hardened howl ithreads javascript jpeg jpeg2k lcms libsamplerate lzo mad
matroska memlimit mikmod mjpeg mmap mng mozcalendar mozdevelop mozsvg mpeg mpi
nls nptl nptlonly ntfs nvidia oggvorbis on-the-fly-crypt openal openexr opengl
pam pda pdflib png ppds qt quicktime real reiserfs sdl sndfile ssl svg svga
symlink tcpd test tetex tga theora threads tidy toolbar truetype unicode usb
videos wmf X xmms xprint xtermtoolbar xvid xvmc yv12 -java -mozilla"

CONFIG_PROTECT_MASK=/etc/conf.d/gpm
CONFIG_PROTECT_MASK=/usr/X11R6/bin/startx

GENTOO_MIRRORS="http://pandemonium.tiscali.de/pub/gentoo/
ftp://ftp.tu-clausthal.de/pub/linux/gentoo/
ftp://ftp.gentoo.mesh-solutions.com/gentoo/
http://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"


ALSA_CARDS="via82xx"

LANG="de_DE@euro"
LC_ALL="de_DE@euro"
GDM_LANG="de_DE@euro"
LINGUAS="de"

-----------------

now usually that has never been a problem but:

magic atti # cfg-update --fix
/etc/make.conf: line 4: CHOST: command not found
/etc/make.conf: line 5: CFLAGS: command not found
/etc/make.conf: line 7: CXXFLAGS: command not found
/etc/make.conf: line 10: MAKEOPTS: command not found
/etc/make.conf: line 11: FEATURES: command not found
/etc/make.conf: line 14: PORT_LOGDIR: command not found
/etc/make.conf: line 41: USE: command not found
Portage Log not found...
Enable PORT_LOGDIR in /etc/make.conf
Recommended: PORT_LOGDIR=/var/log/portage
Make sure the directory exists!

That message is not right. /var/log/portage exists and it contains all logs but
the script does not like lines containing spaces and quotation marks.
When I changed the PORT_LOGDIR to
PORT_LOGDIR=/var/log/portage
there was no more problem with that entry but all other like "cloudn't find
CFLAGS etc. entry".

I know that its quite easy to alter my make.conf to fit the script but I
intentionally made it look that way since it helps me to find things easier. I'm
quite sure you devs do not wite C code like this:
if(1234=23424) then ( i++;x=w-i;for(y=1;x<4;w--){<blabla>};) 
but format the code.

So do I, so please don't answer with "unformat your make.conf" but "we're going
to enhance the script".
thx!

Reproducible: Always
Steps to Reproduce:
cfg-update --fix



magic atti # emerge --info
/etc/make.conf: line 4: CHOST: command not found
/etc/make.conf: line 5: CFLAGS: command not found
/etc/make.conf: line 7: CXXFLAGS: command not found
/etc/make.conf: line 10: MAKEOPTS: command not found
/etc/make.conf: line 11: FEATURES: command not found
/etc/make.conf: line 41: USE: command not found
________________________________________________________________________________

cfg-update 1.7.1 : Building checksum index... cancelled!
                   12 new config file(s) found
                   You should run "cfg-update -u" as soon as possible!
________________________________________________________________________________

Portage 2.0.51.22-r2 (default-linux/amd64/2005.0, gcc-3.4.4, glibc-2.3.5-r1,
2.6.12-gentoo-r4 x86_64)
=================================================================
System uname: 2.6.12-gentoo-r4 x86_64 AMD Athlon(tm) 64 Processor 3000+
Gentoo Base System version 1.6.13
dev-lang/python:     2.3.5
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6
sys-devel/binutils:  2.15.92.0.2-r10
sys-devel/libtool:   1.5.18-r1
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=athlon64 -O3 -pipe -fomit-frame-pointer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env
/usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/
/usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/
/usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /usr/X11R6/bin/startx /etc/env.d"
CXXFLAGS="-march=athlon64 -O3 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig candy distlocks sandbox severe sfperms strict test"
GENTOO_MIRRORS="http://pandemonium.tiscali.de/pub/gentoo/
ftp://ftp.tu-clausthal.de/pub/linux/gentoo/
ftp://ftp.gentoo.mesh-solutions.com/gentoo/
http://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/"
LANG="de_DE@euro"
LC_ALL="de_DE@euro"
LINGUAS="de"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="X a52 aac acpi alsa amd64 audiofile avi berkdb bitmap-fonts bzlib cdr crypt
cups curl dbus dga directfb dlloader dmalloc dpms dts dvd dvdr dvdread eds emacs
encode esd exif fam fame fat fbcon ffmpeg firefox flac foomaticdb fortran gdbm
gif gimpprint gnome gpm gstreamer gtk gtk2 hal hardened howl imagemagick imlib
ipv6 ithreads javascript jpeg jpeg2k kde lcms libsamplerate libwww lzo lzw
lzw-tiff mad matroska memlimit mikmod mjpeg mmap mng mozcalendar mozdevelop
mozsvg mp3 mpeg mpi ncurses nls nptl nptlonly ntfs nvidia ogg oggvorbis
on-the-fly-crypt openal openexr opengl pam pda pdflib perl png ppds python qt
quicktime readline real reiserfs sdl slang sndfile spell ssl svg symlink tcltk
tcpd test tetex tga theora threads tidy tiff toolbar truetype truetype-fonts
type1-fonts unicode usb userlocales videos vorbis wmf xine xml2 xmms xpm xprint
xtermtoolbar xv xvid xvmc yv12 zlib linguas_de userland_GNU kernel_linux
elibc_glibc"
Unset:  ASFLAGS, CTARGET, LDFLAGS, PORTDIR_OVERLAY
Comment 1 Harald van Dijk (RETIRED) gentoo-dev 2005-09-06 23:06:24 UTC
I agree that this should be supported, but I appear to be in the minority, so 
if you report bugs like this against other packages, don't be surprised if some 
are closed as WONTFIX. Just a warning. 
 
That said... could you open /usr/bin/cfg-update in your favourite editor, and  
on line 313, change 
$logdir = `source /etc/make.conf ; echo \$PORT_LOGDIR`; 
to 
$logdir = `portageq envvar PORT_LOGDIR`; 
and report back whether you experience any other issues caused by spacing? If 
this is enough to fix things, I'll add a new revision of cfg-update. 
 
Stephan, would you consider adding this for 1.8.0 (if you haven't yet)? Thanks. 
Comment 2 S. van Boven 2005-09-07 12:11:11 UTC
Version 1.8.0 is nearing completion and I have already implemented the use of 
portageq for getting the values from CONFIG_PROTECT. I think this can also be 
used for getting the PORT_LOGDIR variable without any problems.

I will change the code as Harald suggested and I'll test this when I get home 
later tonight. I have already looked at the code and didn't find similar 
problems.

Thanks for your input!

Harald, after testing I will make a new tarball with the updated script and 
upload it to my ISP's webserver. I'll email you as soon as the ebuild can be 
bumped to version 1.7.2!
Comment 3 Attila Stehr 2005-09-07 14:00:13 UTC
(In reply to comment #1)
> That said... could you open /usr/bin/cfg-update in your favourite editor, and  
> on line 313, change 
> $logdir = `source /etc/make.conf ; echo \$PORT_LOGDIR`; 
> to 
> $logdir = `portageq envvar PORT_LOGDIR`; 
> and report back whether you experience any other issues caused by spacing? If 
> this is enough to fix things, I'll add a new revision of cfg-update. 

Okay, no more problems :)
Thank you!
Comment 4 Harald van Dijk (RETIRED) gentoo-dev 2005-09-07 23:13:44 UTC
Got the e-mail, so 1.7.2 is now in portage, thanks.