Bug 105011 – getdelta.sh can't fetch delta for samba-3.0.14a.tar.gz

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description Stephan Loescher 2005-09-06 06:18:12 UTC]

When I try to fetch the new file samba-3.0.14a.tar.gz via getdelta.sh
(app-portage/getdelta-0.7.0) this error occurs:

Searching for a previously downloaded file in /usr/portage/distfiles
No old version of the requested file found.
The dtu could not be fetched, downloading full file from original URL

With -x it shows the reason:

++ mask_name samba-3.0.14a.tar.gz
++ MASK_FILENAME=samba-3.0.14a.tar.gz
+++ cut -c 1-6
++ '[' samba- = X11R6. ']'
+++ cut -c 1-7
++ '[' samba-3 = firefox ']'
+++ cut -c 1-7
++ '[' samba-3 = MPlayer ']'
+++ sed -e 's/\.bz2$//g' -e 's/\.gz$//g' -e 's/[0-9]//g' -e s/pre//g -e
s/preview//g -e s/beta//g -e s/rc//g -e 's/[\._-]//g' -e 's/\+//g' -e 's/ //g'
++ echo sambaatar
+ mask=sambaatar

The "a" after "14" irritates the program.
I suggest the following patch:

--- getdelta.sh.ORIG    2005-09-06 14:39:45.000000000 +0200
+++ getdelta.sh 2005-09-06 14:58:38.000000000 +0200
@@ -257,6 +257,10 @@
                MASK_FILENAME=$(sed -e "s/try//g" <<< $MASK_FILENAME)
        fi
 
+
+       # Remove letters within the version-number. "samba-3.0.14a.tar.gz"
+       # becomes "samba-3.0.14.tar.gz"
+        MASK_FILENAME=$(perl -pe 's/(\d+)([a-z])(\.tar)/$1$3/g' <<< $MASK_FILENAME)
 
        # ignore some strings in any filename
        echo $(sed -e "s/\.bz2$//g" \

But there ist then still this problem:

Searching for a previously downloaded file in /usr/portage/distfiles
We have following candidates to choose from 
samba-3.0.10.tar.gz
samba-3.0.8.tar.gz
samba-3.0.9.tar.gz 
The best of all is ... samba-3.0.9.tar.gz

This is an bug. The best should be samba-3.0.10.tar.gz
I do not know how to fix this.


Reproducible: Always
Steps to Reproduce:
1. getdelta.sh http://distfiles.gentoo.org/distfiles/samba-3.0.14a.tar.gz

Actual Results:  
No DTU-File or the wrong DTU-File is downloaded.


Expected Results:  
Download the DTU-File for the delta between samba-3.0.10.tar.gz and
samba-3.0.14a.tar.gz and the build the file samba-3.0.14a.tar.gz for further
emerging.

[Comment 1 Stefan Schweizer (RETIRED) 2006-01-21 08:42:19 UTC]

Upstream should handle this, please forward the patch to [e-mail]

[Comment 2 Jakub Moc (RETIRED) 2006-07-27 11:12:39 UTC]

*** Bug 141896 has been marked as a duplicate of this bug. ***

[Comment 3 Nicolai Lissner 2006-08-18 13:44:34 UTC]

fixed in getdelta-0.7.2